Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linter config and address lint warnings/failures #3068

Merged
merged 22 commits into from
Jun 25, 2024

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jun 24, 2024

  • fix whitespace linter
  • fix usestdlibvars
  • fix staticheck
  • ignore spancheck warning
  • fix linter perfsprint
  • fix nolintlint feedback
  • fix nilerr lint checks
  • fix misspell
  • fix mirror lint
  • fix intrange linter
  • fix gofumpt linter
  • fix gosec linter - ignore warning since default min tls version is 1.3
  • fix gocritic linter
  • fix whitespace
  • fix fatcontext linter
  • fix errorlint
  • fix errname linter
  • fix copyloopvar (go1.22) linter
  • fix bodyclose linter
  • update linter config
  • add script to format code

Copy link

knative-prow bot commented Jun 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test-and-release labels Jun 24, 2024
@knative-prow knative-prow bot requested review from aslom and Cali0707 June 24, 2024 01:23
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@knative-prow knative-prow bot requested a review from creydr June 24, 2024 01:23
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 24, 2024
@dprotaso
Copy link
Member Author

/test all

@dprotaso dprotaso closed this Jun 24, 2024
@dprotaso dprotaso reopened this Jun 24, 2024
@dprotaso dprotaso marked this pull request as ready for review June 24, 2024 17:21
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2024
@dprotaso
Copy link
Member Author

/hold

this depends on #3067

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.44%. Comparing base (8535fcc) to head (bf64ccd).
Report is 1 commits behind head on main.

Files Patch % Lines
apis/condition_set.go 0.00% 1 Missing ⚠️
apis/testing/roundtrip/roundtrip.go 0.00% 1 Missing ⚠️
metrics/resource_view.go 0.00% 1 Missing ⚠️
reconciler/configstore.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3068      +/-   ##
==========================================
+ Coverage   78.42%   78.44%   +0.02%     
==========================================
  Files         191      191              
  Lines        8939     8936       -3     
==========================================
  Hits         7010     7010              
+ Misses       1666     1664       -2     
+ Partials      263      262       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

/assign @ReToCode @skonto @pierDipi

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 25, 2024
@dprotaso
Copy link
Member Author

flake TestMetricsExport/OpenCensus

/retest

@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2024
@dprotaso
Copy link
Member Author

Ok - this is ready

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2024
Copy link

knative-prow bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ee1db86 into knative:main Jun 25, 2024
40 checks passed
@dprotaso dprotaso deleted the update-linting branch June 25, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants