Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize prefix remapping map to avoid panic #2453

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Mar 9, 2022

A nil target passed to AsOptionalMap causes a panic.

Signed-off-by: Pierangelo Di Pilato [email protected]

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 9, 2022
@pierDipi pierDipi force-pushed the init-prefix-mapping-map branch from acd73d7 to 87494e8 Compare March 9, 2022 07:12
A `nil` `target` passed to `AsOptionalMap` causes a panic.

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi pierDipi force-pushed the init-prefix-mapping-map branch from 87494e8 to 843d8fb Compare March 9, 2022 07:13
@pierDipi
Copy link
Member Author

pierDipi commented Mar 9, 2022

--- FAIL: TestAdmissionInvalidResponseForResource (0.21s)
    logger.go:130: 2022-03-09T07:23:52.630Z	INFO	webhook/webhook.go:198	Informers have been synced, unblocking admission webhooks.
    logger.go:130: 2022-03-09T07:23:52.736Z	ERROR	webhook/webhook.go:148	failed to fetch secret	{"error": "secret \"webhook-certs\" not found"}
    admission_integration_test.go:403: Failed to receive response Get "https://0.0.0.0:39661/booger": remote error: tls: unrecognized name
    logger.go:130: 2022-03-09T07:23:52.736Z	INFO	webhook/webhook.go:240	Starting to fail readiness probes...
2022/03/09 07:23:52 http: TLS handshake error from 127.0.0.1:39998: EOF
2022/03/09 07:23:53 http: TLS handshake error from 127.0.0.1:37770: EOF
2022/03/09 07:23:53 http: TLS handshake error from 127.0.0.1:60496: EOF
2022/03/09 07:23:53 http: TLS handshake error from 127.0.0.1:43356: EOF
FAIL

#2432

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #2453 (843d8fb) into main (d2cdc68) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2453      +/-   ##
==========================================
+ Coverage   63.55%   63.60%   +0.04%     
==========================================
  Files         228      228              
  Lines        9999    10000       +1     
==========================================
+ Hits         6355     6360       +5     
+ Misses       3342     3340       -2     
+ Partials      302      300       -2     
Impacted Files Coverage Δ
leaderelection/config.go 80.00% <100.00%> (+0.40%) ⬆️
test/gcs/mock/mock.go 93.54% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2cdc68...843d8fb. Read the comment docs.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@knative-prow-robot knative-prow-robot merged commit ce6f287 into knative:main Mar 10, 2022
@pierDipi
Copy link
Member Author

/cherry-pick release-1.3

@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #2459

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants