-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize prefix remapping map to avoid panic #2453
Initialize prefix remapping map to avoid panic #2453
Conversation
acd73d7
to
87494e8
Compare
A `nil` `target` passed to `AsOptionalMap` causes a panic. Signed-off-by: Pierangelo Di Pilato <[email protected]>
87494e8
to
843d8fb
Compare
|
Codecov Report
@@ Coverage Diff @@
## main #2453 +/- ##
==========================================
+ Coverage 63.55% 63.60% +0.04%
==========================================
Files 228 228
Lines 9999 10000 +1
==========================================
+ Hits 6355 6360 +5
+ Misses 3342 3340 -2
+ Partials 302 300 -2
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.3 |
@pierDipi: new pull request created: #2459 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
A
nil
target
passed toAsOptionalMap
causes a panic.Signed-off-by: Pierangelo Di Pilato [email protected]