Fix Kourier bootstrap namespace - #2336
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
@kahirokunn: 0 warnings.
Details
In response to this:
Fixes #
Proposed Changes
- Use the Kourier bootstrap ConfigMap namespace to replace the default namespace embedded in its Envoy bootstrap configuration.
- Handle the raw ConfigMap data that the common namespace transformer cannot update, following the existing
replaceGatewayNamespacepattern.- Add regression coverage for installing Knative Serving outside the
knative-servingnamespace.Release Note
Fix Kourier connectivity when Knative Serving is installed in a non-default namespace.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
==========================================
+ Coverage 63.89% 63.99% +0.09%
==========================================
Files 55 55
Lines 2479 2491 +12
==========================================
+ Hits 1584 1594 +10
- Misses 776 777 +1
- Partials 119 120 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
d11a394 to
999ba3a
Compare
|
/ok-to-test |
Fixes #
Proposed Changes
replaceGatewayNamespacepattern.knative-servingnamespace.Release Note