Skip to content

Fix Kourier bootstrap namespace - #2336

Open
kahirokunn wants to merge 1 commit into
knative:mainfrom
kahirokunn:fix-kourier-custom-namespace-bootstrap
Open

Fix Kourier bootstrap namespace#2336
kahirokunn wants to merge 1 commit into
knative:mainfrom
kahirokunn:fix-kourier-custom-namespace-bootstrap

Conversation

@kahirokunn

Copy link
Copy Markdown
Member

Fixes #

Proposed Changes

  • Use the Kourier bootstrap ConfigMap namespace to replace the default namespace embedded in its Envoy bootstrap configuration.
  • Handle the raw ConfigMap data that the common namespace transformer cannot update, following the existing replaceGatewayNamespace pattern.
  • Add regression coverage for installing Knative Serving outside the knative-serving namespace.

Release Note

Fix Kourier connectivity when Knative Serving is installed in a non-default namespace.

@knative-prow knative-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2026
@knative-prow

knative-prow Bot commented Aug 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please assign houshengbo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
knative-prow Bot requested review from aliok and matzew August 10, 2026 03:02

@knative-prow knative-prow Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kahirokunn: 0 warnings.

Details

In response to this:

Fixes #

Proposed Changes

  • Use the Kourier bootstrap ConfigMap namespace to replace the default namespace embedded in its Envoy bootstrap configuration.
  • Handle the raw ConfigMap data that the common namespace transformer cannot update, following the existing replaceGatewayNamespace pattern.
  • Add regression coverage for installing Knative Serving outside the knative-serving namespace.

Release Note

Fix Kourier connectivity when Knative Serving is installed in a non-default namespace.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.99%. Comparing base (8f00498) to head (999ba3a).

Files with missing lines Patch % Lines
pkg/reconciler/knativeserving/ingress/kourier.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2336      +/-   ##
==========================================
+ Coverage   63.89%   63.99%   +0.09%     
==========================================
  Files          55       55              
  Lines        2479     2491      +12     
==========================================
+ Hits         1584     1594      +10     
- Misses        776      777       +1     
- Partials      119      120       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@kahirokunn
kahirokunn force-pushed the fix-kourier-custom-namespace-bootstrap branch from d11a394 to 999ba3a Compare August 10, 2026 03:08
@kahirokunn

Copy link
Copy Markdown
Member Author

/ok-to-test

@knative-prow knative-prow Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant