-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix grpc dialing #1036
fix grpc dialing #1036
Conversation
/assign @skonto |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
=======================================
Coverage 93.14% 93.14%
=======================================
Files 36 36
Lines 1255 1255
=======================================
Hits 1169 1169
Misses 72 72
Partials 14 14 ☔ View full report in Codecov by Sentry. |
/override "Unit Test (knative-extensions/net-gateway-api)" Downstream k8s deps need to be unpinned from |
@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (knative-extensions/net-gateway-api) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
resolver changed we want to use
passthrough
as mentioned here https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md