Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grpc dialing #1036

Merged
merged 1 commit into from
Jan 13, 2025
Merged

fix grpc dialing #1036

merged 1 commit into from
Jan 13, 2025

Conversation

dprotaso
Copy link
Member

resolver changed we want to use passthrough as mentioned here https://github.com/grpc/grpc-go/blob/master/Documentation/anti-patterns.md

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2025
@knative-prow knative-prow bot requested review from izabelacg and skonto January 13, 2025 18:24
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 13, 2025
@dprotaso
Copy link
Member Author

/assign @skonto

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (22a6457) to head (800e074).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          36       36           
  Lines        1255     1255           
=======================================
  Hits         1169     1169           
  Misses         72       72           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

dprotaso commented Jan 13, 2025

/override "Unit Test (knative-extensions/net-gateway-api)"

Downstream k8s deps need to be unpinned from

Copy link

knative-prow bot commented Jan 13, 2025

@dprotaso: Overrode contexts on behalf of dprotaso: Unit Test (knative-extensions/net-gateway-api)

In response to this:

/override "Unit Test (knative-extensions/net-gateway-api)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@skonto
Copy link
Contributor

skonto commented Jan 13, 2025

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
Copy link

knative-prow bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 47d62db into knative:main Jan 13, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants