Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests for Backstage #508

Merged
merged 4 commits into from
Aug 22, 2024
Merged

More tests for Backstage #508

merged 4 commits into from
Aug 22, 2024

Conversation

aliok
Copy link
Member

@aliok aliok commented Aug 20, 2024

Which issue(s) this PR fixes:

Fixes

@aliok
Copy link
Member Author

aliok commented Aug 20, 2024

cc @pierDipi @dsimansk

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 20, 2024
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 20, 2024
@aliok
Copy link
Member Author

aliok commented Aug 21, 2024

Related: knative-extensions/backstage-plugins#78

@aliok aliok mentioned this pull request Aug 21, 2024
Merged
@aliok
Copy link
Member Author

aliok commented Aug 21, 2024

Resources updated, new look please?

pierDipi
pierDipi approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2024
@knative-prow knative-prow bot merged commit f56ead3 into knative:main Aug 22, 2024
17 checks passed
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 22, 2024

@aliok: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key backstage-plugins-main.gen.yaml using file prow/jobs/generated/knative-extensions/backstage-plugins-main.gen.yaml

In response to this:

Which issue(s) this PR fixes:

Fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aliok aliok deleted the 2024-08-20-prow-e2e-tests-for-backstage branch August 22, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk dsimansk left review comments

@pierDipi pierDipi pierDipi approved these changes

@upodroid upodroid upodroid approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@upodroid upodroid

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aliok @dsimansk @upodroid @pierDipi