Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the repo autoscaler-keda #440

Merged
merged 1 commit into from
May 21, 2024
Merged

Added the repo autoscaler-keda #440

merged 1 commit into from
May 21, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented May 21, 2024

Which issue(s) this PR fixes:

Fixes

@knative-prow knative-prow bot requested review from mgencur and upodroid May 21, 2024 12:15
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 21, 2024
@skonto
Copy link
Contributor Author

skonto commented May 21, 2024

/assign @ReToCode

@skonto
Copy link
Contributor Author

skonto commented May 21, 2024

/assign @mgencur

@skonto
Copy link
Contributor Author

skonto commented May 21, 2024 •
edited
Loading

autoscaler-keda repo is still empty but I am working on a PR to bring in the content, so tests will be run against that PR, after this is merged. 🤞

ReToCode
ReToCode approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@knative-prow knative-prow bot merged commit 013abf7 into knative:main May 21, 2024
18 checks passed
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 21, 2024

@skonto: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key autoscaler-keda-main.gen.yaml using file prow/jobs/generated/knative-extensions/autoscaler-keda-main.gen.yaml

In response to this:

Which issue(s) this PR fixes:

Fixes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@ReToCode ReToCode ReToCode approved these changes

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@mgencur mgencur

@ReToCode ReToCode

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skonto @ReToCode @upodroid @mgencur