Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added KEDA reconciler test to ekb #188

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Added KEDA reconciler test to ekb #188

merged 1 commit into from
Sep 14, 2023

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Sep 8, 2023

Which issue(s) this PR fixes:

Fixes knative-extensions/eventing-kafka-broker#3067

/hold until after knative-extensions/eventing-kafka-broker#3322 is merged

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
@Cali0707
Copy link
Member Author

Cali0707 commented Sep 8, 2023

/cc @matzew @pierDipi

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 8, 2023
@Cali0707 Cali0707 mentioned this pull request Sep 8, 2023
Merged
pierDipi
pierDipi approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@krsna-m krsna-m removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2023
@knative-prow knative-prow bot merged commit 054c536 into knative:main Sep 14, 2023
12 checks passed
@knative-prow
Copy link

knative-prow bot commented Sep 14, 2023

@Cali0707: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eventing-kafka-broker-main.gen.yaml using file prow/jobs/generated/knative-extensions/eventing-kafka-broker-main.gen.yaml

In response to this:

Which issue(s) this PR fixes:

Fixes knative-extensions/eventing-kafka-broker#3067

/hold until after knative-extensions/eventing-kafka-broker#3322 is merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@psschwei psschwei Awaiting requested review from psschwei

@upodroid upodroid Awaiting requested review from upodroid

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test KafkaSource with KEDA
3 participants
@Cali0707 @pierDipi @krsna-m