Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump go to 1.21 #184

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Bump go to 1.21 #184

merged 2 commits into from
Sep 5, 2023

Conversation

krsna-m
Copy link
Contributor

@krsna-m krsna-m commented Sep 5, 2023 •
edited
Loading

Also fixes the GVM issue we have been seeing.

moovweb/gvm#438

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2023
@krsna-m krsna-m mentioned this pull request Sep 5, 2023
Closed
Cali0707
Cali0707 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1fde412 into knative:main Sep 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@cardil cardil Awaiting requested review from cardil

@psschwei psschwei Awaiting requested review from psschwei

@dprotaso dprotaso Awaiting requested review from dprotaso

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krsna-m @Cali0707