Python Middleware v2 Scaffolding #2685
Conversation
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
kind/enhancement
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow-robot
added
the
needs-rebase
knative-prow
bot
added
the
size/XXL
|
nice for getting this started |
lkingland
force-pushed
the
scaffolding-python
branch
from
ec91040 to
182c74c
Compare
Inbuilt templates should be limited to a base http and cloudevent integration, with anything beyond this falling to the officially supported functions samples repository.
Until the Python middleware is supported by the Pack builder, the E2E tests will need to be disabled.
lkingland
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
The target platform for a test needs to be a platform which is available in all test base images. That's usually linux. Using current OS would fail, for example, building python containers on MacOS because the official Python base image has no darwin layer.
lkingland
force-pushed
the
scaffolding-python
branch
3 times, most recently
from
7488267 to
a51bd6a
Compare
lkingland
force-pushed
the
scaffolding-python
branch
from
a51bd6a to
9ecb85c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
+ Coverage 62.59% 62.64% +0.04%
==========================================
Files 131 131
Lines 15588 15921 +333
==========================================
+ Hits 9758 9974 +216
- Misses 4904 4995 +91
- Partials 926 952 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| #!/bin/bash | ||
|
|
||
| function is_django_installed() { | ||
| python -c "import django" &>/dev/null |
knative-prow-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| @@ -0,0 +1,26 @@ | |||
| [project] | |||
There was a problem hiding this comment.
this is for poetry, right?
Would it make sense to have a requirements.txt as well - for pip?
Or would this not work?
I am not really an expert there, but would perhaps like in some section mentioned why pyproject / poetry vs pip ?
|
ON, https://github.com/lkingland/func/tree/scaffolding-python/templates/python |
| @@ -12,7 +12,7 @@ jobs: | |||
| continue-on-error: true | |||
| strategy: | |||
| matrix: | |||
| runtime: ["node", "go", "python", "quarkus", "springboot", "typescript", "rust"] | |||
There was a problem hiding this comment.
Why has been python removed here?
Changes
🎁 Host builder now supports Python Functions
🎁 Can now
func runPython Functions locally outside of a container (no container runtime required)🎁 Python Functions now suppport instanced method signatures
🎁 Python Functions now support lifecycle events (start, stop, readiness, liveness)
🎁 Updates Python Template Tests to use pytest
🎁 Python Functions now use the ASGI Spec and run using an ASGI optimized server
🎁 adds support for base images to the OCI builder
🧹 Cleans up .gitignore
🧹 Cleans up and simplifies the OCI builder
🧹 Cleans up and simplifies the repository management code
🧹 removes broken interactive prompts from the
runcommand pending forthcoming UX update/kind enhancement
Fixes #
Release Note
Docs