Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make array when filters is nil #2569

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 5, 2024

Changes

  • fixes 2567

/kind

Fixes #

Release Note


Docs


Signed-off-by: Matthias Wessendorf <[email protected]>
Copy link

knative-prow bot commented Nov 5, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • fixes 2567

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from nainaz and rhuss November 5, 2024 13:24
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
Copy link

knative-prow bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member Author

matzew commented Nov 5, 2024

/cherry-pick release-1.16

@knative-prow-robot
Copy link

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member Author

matzew commented Nov 5, 2024

/cherry-pick release-1.15

@knative-prow-robot
Copy link

@matzew: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.39%. Comparing base (2b83bac) to head (9fbd925).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/subscribe.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2569      +/-   ##
==========================================
+ Coverage   64.14%   65.39%   +1.25%     
==========================================
  Files         130      130              
  Lines       15479    15482       +3     
==========================================
+ Hits         9929    10125     +196     
+ Misses       4614     4382     -232     
- Partials      936      975      +39     
Flag Coverage Δ
e2e-test 35.90% <0.00%> (-0.01%) ⬇️
e2e-test-oncluster 32.82% <0.00%> (-0.07%) ⬇️
e2e-test-oncluster-runtime 28.64% <0.00%> (?)
e2e-test-runtime-go 26.45% <0.00%> (?)
e2e-test-runtime-node 25.85% <0.00%> (?)
e2e-test-runtime-python 25.85% <0.00%> (?)
e2e-test-runtime-quarkus 26.00% <0.00%> (?)
e2e-test-runtime-rust 25.01% <0.00%> (?)
e2e-test-runtime-springboot 25.05% <0.00%> (?)
e2e-test-runtime-typescript 25.96% <0.00%> (?)
integration-tests 51.94% <25.00%> (+2.29%) ⬆️
unit-tests 50.87% <25.00%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit ff6053a into knative:main Nov 5, 2024
39 checks passed
@knative-prow-robot
Copy link

@matzew: new pull request created: #2570

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link

@matzew: new pull request created: #2571

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants