Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Upgrade to latest dependencies #2564

Merged
merged 1 commit into from
Nov 5, 2024
Merged

[main] Upgrade to latest dependencies #2564

merged 1 commit into from
Nov 5, 2024

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-automation
upgrade to latest dependencies
4369c90 
bumping knative.dev/serving 135b667...423e654:
  > 423e654 Fix configuration metadata inconsistency (# 15601)
bumping knative.dev/eventing 7bca815...fa6b4c5:
  > fa6b4c5 Add jobsinks-addressable-resolver cluster role (# 8298)
  > b4b609a Add observedGeneration in JobSink OpenAPI schema (# 8297)
  > 2e4d353 Allow imc-controller to list JobSinks (# 8294)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 4, 2024

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative/func-approvers.

Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Cron -knative-prow-robot

/cc knative/func-approvers
/assign knative/func-approvers

Produced by: knative-extensions/knobots/actions/update-deps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.43%. Comparing base (b95785d) to head (4369c90).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2564      +/-   ##
==========================================
+ Coverage   63.05%   65.43%   +2.37%     
==========================================
  Files         130      130              
  Lines       15479    15479              
==========================================
+ Hits         9760    10128     +368     
+ Misses       4810     4378     -432     
- Partials      909      973      +64
Flag Coverage Δ
e2e-test 35.91% <ø> (-0.05%) ⬇️
e2e-test-oncluster 32.86% <ø> (?)
e2e-test-oncluster-runtime 28.65% <ø> (?)
e2e-test-runtime-go 26.45% <ø> (?)
e2e-test-runtime-node 25.86% <ø> (?)
e2e-test-runtime-python 25.86% <ø> (?)
e2e-test-runtime-quarkus 26.01% <ø> (?)
e2e-test-runtime-rust 24.99% <ø> (?)
e2e-test-runtime-springboot 25.06% <ø> (?)
e2e-test-runtime-typescript 25.96% <ø> (?)
integration-tests 51.93% <ø> (+2.31%) ⬆️
unit-tests 50.90% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@knative-prow knative-prow bot merged commit 2b83bac into knative:main Nov 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-automation @matzew