Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary clause from Dockerfile #2513

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

matejvasek
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2024
@matejvasek matejvasek requested review from matzew, lkingland and gauron99 and removed request for dsimansk and jrangelramos September 23, 2024 16:16
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.11%. Comparing base (2312afc) to head (efbe612).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2513      +/-   ##
==========================================
+ Coverage   61.57%   67.11%   +5.53%     
==========================================
  Files         129      129              
  Lines       15418    11990    -3428     
==========================================
- Hits         9494     8047    -1447     
+ Misses       4989     2972    -2017     
- Partials      935      971      +36     
Flag Coverage Δ
e2e-test 36.48% <ø> (-0.03%) ⬇️
e2e-test-oncluster 33.34% <ø> (+0.01%) ⬆️
e2e-test-oncluster-runtime 29.75% <ø> (?)
e2e-test-runtime-go 26.54% <ø> (?)
e2e-test-runtime-node 25.93% <ø> (?)
e2e-test-runtime-python 25.93% <ø> (?)
e2e-test-runtime-quarkus 26.02% <ø> (?)
e2e-test-runtime-rust 25.05% <ø> (?)
e2e-test-runtime-springboot 25.09% <ø> (?)
e2e-test-runtime-typescript 26.01% <ø> (?)
integration-tests 53.22% <ø> (+2.38%) ⬆️
unit-tests 51.42% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek
Copy link
Contributor Author

@dsimansk plz override codecov/project

@matejvasek
Copy link
Contributor Author

PTAL @lkingland @gauron99 @matzew

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
Copy link

knative-prow bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dsimansk
Copy link
Contributor

/override codecov/project

Copy link

knative-prow bot commented Sep 24, 2024

@dsimansk: Overrode contexts on behalf of dsimansk: codecov/project

In response to this:

/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 783d04d into knative:main Sep 24, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants