Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix git 2 #2501

Closed
Closed

Conversation

matejvasek
Copy link
Contributor

Changes

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Sep 14, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

CLA Not Signed

Copy link

knative-prow bot commented Sep 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 14, 2024
@matejvasek matejvasek closed this Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 57.57576% with 14 lines in your changes missing coverage. Please review.

Project coverage is 66.55%. Comparing base (84f4caf) to head (62959ff).

Files with missing lines Patch % Lines
pkg/testing/testing.go 56.25% 8 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
+ Coverage   60.72%   66.55%   +5.82%     
==========================================
  Files         129      129              
  Lines       15351    11960    -3391     
==========================================
- Hits         9322     7960    -1362     
+ Misses       5131     3029    -2102     
- Partials      898      971      +73     
Flag Coverage Δ
e2e-test 37.53% <0.00%> (+0.92%) ⬆️
e2e-test-runtime-go 26.61% <0.00%> (?)
e2e-test-runtime-node 26.00% <0.00%> (?)
e2e-test-runtime-python 26.00% <0.00%> (?)
e2e-test-runtime-quarkus 26.09% <0.00%> (?)
e2e-test-runtime-rust 25.10% <0.00%> (?)
e2e-test-runtime-springboot 25.18% <0.00%> (?)
e2e-test-runtime-typescript 26.08% <0.00%> (?)
integration-tests 53.04% <57.57%> (+2.34%) ⬆️
unit-tests 51.25% <57.57%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants