Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go socat #2479

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Go socat #2479

merged 1 commit into from
Sep 24, 2024

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Sep 4, 2024

Changes

Minimalistic socat written in Go.

Copy link

knative-prow bot commented Sep 4, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Sep 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2024
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 87.65432% with 10 lines in your changes missing coverage. Please review.

Project coverage is 66.87%. Comparing base (2312afc) to head (5f4b095).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/func-util/socat.go 87.65% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2479      +/-   ##
==========================================
+ Coverage   61.57%   66.87%   +5.29%     
==========================================
  Files         129      130       +1     
  Lines       15418    12071    -3347     
==========================================
- Hits         9494     8072    -1422     
+ Misses       4989     3019    -1970     
- Partials      935      980      +45     
Flag Coverage Δ
e2e-test 36.50% <ø> (ø)
e2e-test-oncluster 33.32% <ø> (ø)
e2e-test-oncluster-runtime 29.62% <ø> (?)
e2e-test-runtime-go 26.54% <ø> (?)
e2e-test-runtime-node 25.93% <ø> (?)
e2e-test-runtime-python 25.93% <ø> (?)
e2e-test-runtime-quarkus 26.02% <ø> (?)
e2e-test-runtime-rust 25.07% <ø> (?)
e2e-test-runtime-springboot 25.11% <ø> (?)
e2e-test-runtime-typescript 26.01% <ø> (?)
integration-tests 53.07% <87.65%> (+2.23%) ⬆️
unit-tests 51.68% <87.65%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matejvasek matejvasek changed the title [WIP] Go socat Sep 23, 2024
@matejvasek matejvasek requested review from matzew, gauron99 and lkingland and removed request for maximilien September 23, 2024 16:10
@matejvasek matejvasek marked this pull request as ready for review September 23, 2024 16:10
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2024
@knative-prow knative-prow bot requested a review from rhuss September 23, 2024 16:10
@matejvasek
Copy link
Contributor Author

PTAL @lkingland @matzew @gauron99

@lkingland
Copy link
Member

lkingland commented Sep 24, 2024

socool
/approve
/lgtm

Copy link

knative-prow bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkingland lkingland added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2024
@knative-prow knative-prow bot merged commit 63e3e52 into knative:main Sep 24, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants