Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] #2479

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] #2479

wants to merge 1 commit into from

Conversation

matejvasek
Copy link
Contributor

Changes

/kind

Fixes #

Release Note


Docs


Signed-off-by: Matej Vašek <[email protected]>
Copy link

knative-prow bot commented Sep 4, 2024

@matejvasek: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Sep 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2024
Copy link

knative-prow bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 4, 2024
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 87.34177% with 10 lines in your changes missing coverage. Please review.

Project coverage is 61.14%. Comparing base (e937035) to head (c273693).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/func-util/socat.go 87.34% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2479      +/-   ##
==========================================
- Coverage   61.54%   61.14%   -0.40%     
==========================================
  Files         129      128       -1     
  Lines       15334    11999    -3335     
==========================================
- Hits         9437     7337    -2100     
+ Misses       4971     3645    -1326     
- Partials      926     1017      +91     
Flag Coverage Δ
e2e-test 36.61% <ø> (-0.05%) ⬇️
e2e-test-oncluster 33.35% <ø> (-0.09%) ⬇️
e2e-test-oncluster-runtime 29.45% <ø> (?)
e2e-test-runtime-go 26.63% <ø> (?)
e2e-test-runtime-node 26.00% <ø> (?)
e2e-test-runtime-python 26.00% <ø> (?)
e2e-test-runtime-quarkus 26.10% <ø> (?)
e2e-test-runtime-rust 25.15% <ø> (?)
e2e-test-runtime-springboot 25.18% <ø> (?)
e2e-test-runtime-typescript 26.09% <ø> (?)
integration-tests 53.00% <87.34%> (+2.24%) ⬆️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant