Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s2i builder go support #2203

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

lkingland
Copy link
Member

@lkingland lkingland commented Mar 5, 2024

Changes

  • 🎁 S2I builder now supports Go functions
  • 🎁 S2I Go functions now include Instance-based method signatures and lifecycle events

/kind enhancement

Release Note

The S2I builder now supports Go functions.
Go functions built with the S2I builder now support the new instance-based method signatures and lifecycle methods.

Copy link

knative-prow bot commented Mar 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added kind/enhancement do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 5, 2024
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 5, 2024
@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 5, 2024
@knative-prow knative-prow bot requested review from rhuss and vyasgun March 5, 2024 05:59
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2024
cmd/build.go Outdated Show resolved Hide resolved
// such that the "go build" command builds subdirectory .s2i/builds/by-func/last
// (where main resides) rather than the root.
// TODO: many apps use the pattern of having main in a subdirectory, for
// example the idiomatic "./cmd/myapp/main.go". It would therefore be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we raise a GH issue for this?

Copy link
Member Author

@lkingland lkingland Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should. Any idea where that repository is hosted? A cursory search found nothing for me

pkg/builders/s2i/builder.go Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 21, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 10, 2024
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 57.57576% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 58.61%. Comparing base (e6fa020) to head (c5bebc3).

Files Patch % Lines
pkg/builders/s2i/builder.go 56.66% 15 Missing and 11 partials ⚠️
pkg/builders/s2i/assemblers.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2203      +/-   ##
==========================================
- Coverage   60.17%   58.61%   -1.57%     
==========================================
  Files         127      126       -1     
  Lines       14784    11479    -3305     
==========================================
- Hits         8896     6728    -2168     
+ Misses       4981     3786    -1195     
- Partials      907      965      +58     
Flag Coverage Δ
e2e-test 38.02% <0.00%> (-0.12%) ⬇️
e2e-test-oncluster 31.17% <0.00%> (-0.11%) ⬇️
e2e-test-oncluster-runtime 27.17% <0.00%> (?)
integration-tests 50.16% <57.57%> (+1.19%) ⬆️
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@lkingland lkingland requested review from matejvasek and gauron99 and removed request for rhuss and vyasgun May 10, 2024 00:20
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 17, 2024
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 17, 2024
@lkingland lkingland marked this pull request as ready for review May 17, 2024 08:48
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 17, 2024
@knative-prow knative-prow bot requested review from jrangelramos and rhuss May 17, 2024 08:48
@lkingland lkingland requested review from matzew and removed request for jrangelramos and rhuss May 17, 2024 11:00
Copy link
Contributor

@gauron99 gauron99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🎉
/hold for others

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
Copy link

knative-prow bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkingland lkingland removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@knative-prow knative-prow bot merged commit b0418f9 into knative:main May 21, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants