Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor cluster allocation script to use latest Knative bits #2197

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

dsimansk
Copy link
Contributor

Changes

  • chore: Refactor cluster allocation script to use latest Knative bits

IMO it could be pushed further to wrap also kn binary version. But for now it seemed to me like a super quick win. Functions are inspired by client and hack scripts. i.e. a bit verified. :)

/cc @matejvasek @lkingland

Release Note

NONE

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 29, 2024
@dsimansk
Copy link
Contributor Author

@lkingland
Copy link
Member

I certainly appreciate the addition; quick win indeed. Thanks @dsimansk
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
Copy link

knative-prow bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit c9cdfad into knative:main Mar 4, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants