Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Removing the vendor dir 🎆 #1966

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

cardil
Copy link
Contributor

@cardil cardil commented Sep 7, 2023

Changes

  • 🧹 Removing the vendor dir 🎆

/kind cleanup

Tests knative/hack#311
Tests knative/hack#222
Related to knative-extensions/kn-plugin-event#307

@knative-prow knative-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 7, 2023
@cardil cardil mentioned this pull request Sep 7, 2023
17 tasks
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (26614eb) 60.64% compared to head (5963269) 62.75%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1966      +/-   ##
==========================================
+ Coverage   60.64%   62.75%   +2.11%     
==========================================
  Files         106      106              
  Lines       13693    13693              
==========================================
+ Hits         8304     8593     +289     
+ Misses       4569     4231     -338     
- Partials      820      869      +49     
Flag Coverage Δ
e2e-test 36.46% <ø> (+1.27%) ⬆️
e2e-test-oncluster 30.50% <ø> (?)
e2e-test-oncluster-runtime 26.96% <ø> (?)
e2e-test-runtime-go 25.59% <ø> (?)
e2e-test-runtime-node 26.60% <ø> (?)
e2e-test-runtime-python 26.60% <ø> (?)
e2e-test-runtime-quarkus 26.71% <ø> (?)
e2e-test-runtime-rust 25.59% <ø> (?)
e2e-test-runtime-springboot 25.73% <ø> (?)
integration-tests 51.42% <ø> (+2.09%) ⬆️
unit-tests-macos-latest 48.21% <ø> (+0.02%) ⬆️
unit-tests-ubuntu-latest 48.98% <ø> (-0.03%) ⬇️
unit-tests-windows-latest 48.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cardil
Copy link
Contributor Author

cardil commented Sep 7, 2023

Error from https://github.com/knative/func/actions/runs/6108788480/job/16578494890?pr=1966#step:10:199 looks like infra related:

Error: preparing container for next step: creating build container: creating container: creating read-write layer with ID "75ac42ff146caa497d0a1b90a87bd6db05861249d055ee23e0557339b2161ec0": no space left on device

@cardil
Copy link
Contributor Author

cardil commented Sep 7, 2023

https://github.com/knative/func/actions/runs/6108788480/job/16580443298#step:10:1 once again: no space left on the device

@cardil
Copy link
Contributor Author

cardil commented Sep 7, 2023

This PR is looking good (apart from obvious infra failures - seen above).

However, I'll put this on hold, since I'll be on PTO next week.

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2023
@lkingland
Copy link
Member

/lgtm

Thanks for the improvement! Re-running the E2E test...

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@matejvasek
Copy link
Contributor

@cardil to fix the failing test please rebase on main.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 25, 2023

New changes are detected. LGTM label has been removed.

@lkingland lkingland added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 25, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b6fb880 into knative:main Sep 25, 2023
39 checks passed
@cardil cardil deleted the cleanup/vendorless branch September 26, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants