-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Removing the vendor dir 🎆 #1966
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1966 +/- ##
==========================================
+ Coverage 60.64% 62.75% +2.11%
==========================================
Files 106 106
Lines 13693 13693
==========================================
+ Hits 8304 8593 +289
+ Misses 4569 4231 -338
- Partials 820 869 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Error from https://github.com/knative/func/actions/runs/6108788480/job/16578494890?pr=1966#step:10:199 looks like infra related:
|
https://github.com/knative/func/actions/runs/6108788480/job/16580443298#step:10:1 once again: |
This PR is looking good (apart from obvious infra failures - seen above). However, I'll put this on hold, since I'll be on PTO next week. /hold |
/lgtm Thanks for the improvement! Re-running the E2E test... |
@cardil to fix the failing test please rebase on |
ffc4452
to
fcb052e
Compare
New changes are detected. LGTM label has been removed. |
fcb052e
to
5963269
Compare
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: cardil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind cleanup
Tests knative/hack#311
Tests knative/hack#222
Related to knative-extensions/kn-plugin-event#307