Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: make update-runtimes #1822

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

lkingland
Copy link
Member

  • 🎁 make update-runtimes will update scaffold runtimes (Go only for now)
  • 🧹 Standardizes pluraility of "Cloudevents"
  • 🧹 updates the func-runtime-go to v0.2.3

/kind cleanup

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2023
@lkingland lkingland requested review from lance, salaboy, zroubalik, aslom and matejvasek and removed request for navidshaikh and vyasgun June 21, 2023 07:04
@lkingland lkingland marked this pull request as ready for review June 21, 2023 07:05
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@knative-prow knative-prow bot requested review from dsimansk and rhuss June 21, 2023 07:05
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +3.70 🎉

Comparison is base (7b5bd33) 59.86% compared to head (a5525fd) 63.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1822      +/-   ##
==========================================
+ Coverage   59.86%   63.57%   +3.70%     
==========================================
  Files         107      107              
  Lines       13645    13645              
==========================================
+ Hits         8169     8675     +506     
+ Misses       4698     4140     -558     
- Partials      778      830      +52     
Flag Coverage Δ
e2e-test 35.45% <0.00%> (?)
e2e-test-oncluster 31.32% <0.00%> (-0.03%) ⬇️
e2e-test-oncluster-runtime 26.82% <0.00%> (?)
e2e-test-runtime-go 25.76% <0.00%> (?)
e2e-test-runtime-node 26.72% <0.00%> (?)
e2e-test-runtime-python 26.72% <0.00%> (?)
e2e-test-runtime-quarkus 26.84% <0.00%> (?)
e2e-test-runtime-springboot 25.90% <0.00%> (?)
e2e-test-runtime-typescript 26.84% <0.00%> (?)
integration-tests 51.69% <100.00%> (+3.60%) ⬆️
unit-tests-macos-latest 49.53% <100.00%> (+0.02%) ⬆️
unit-tests-ubuntu-latest 50.27% <100.00%> (+0.03%) ⬆️
unit-tests-windows-latest 49.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/scaffolding/signatures.go 100.00% <100.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
- Updates func-runtime-go 20 v0.2.3
- Create an 'update-runtimes' make target
- Standardizes plurality of "Cloudevents" throughout
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2023
@knative-prow
Copy link

knative-prow bot commented Jun 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8a078ce into knative:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants