-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add RequestReply types and CRD #8337
Conversation
Signed-off-by: Cali0707 <[email protected]>
Signed-off-by: Cali0707 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8337 +/- ##
=======================================
Coverage ? 64.53%
=======================================
Files ? 380
Lines ? 22772
Branches ? 0
=======================================
Hits ? 14697
Misses ? 7300
Partials ? 775 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
||
func (rrs *RequestReplySpec) SetDefaults(ctx context.Context) { | ||
if rrs.Timeout == nil || *rrs.Timeout == "" { | ||
rrs.Timeout = ptr.To("30s") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could make this globally configurable in the features flag config map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #8177
Proposed Changes
Release Note