chore: correct comments #8336
Merged
chore: correct comments #8336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Wessendorf <[email protected]>
knative-prow
bot
added
the
size/XS
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8336 +/- ##
=======================================
Coverage ? 64.53%
=======================================
Files ? 375
Lines ? 22666
Branches ? 0
=======================================
Hits ? 14628
Misses ? 7271
Partials ? 767 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test upgrade-tests |
matzew
added a commit
to matzew/eventing
that referenced
this pull request
Feb 13, 2025
💄 correct comments ... Signed-off-by: Matthias Wessendorf <[email protected]>
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Feb 14, 2025
* IntegrationSource CRD (knative#8238) * Add initial raw API types and controller/reconciler. Levering internally the container source for the handling of the kamelet workloads. the logic for applying the env-vars is a bit verbose, but can be improved. Tests/lifeccyle and some other improvements are still missing. but this works. Signed-off-by: Matthias Wessendorf <[email protected]> * adding reflection to make the mapping less verbose, and more flexible to extend... Signed-off-by: Matthias Wessendorf <[email protected]> * Add DDB Streams Signed-off-by: Matthias Wessendorf <[email protected]> * polish and add minimal tests Signed-off-by: Matthias Wessendorf <[email protected]> * Update pkg/apis/sources/v1alpha1/integration_lifecycle.go Co-authored-by: Pierangelo Di Pilato <[email protected]> * Update pkg/apis/sources/v1alpha1/integration_lifecycle.go Co-authored-by: Pierangelo Di Pilato <[email protected]> * Fix compiler warnings Signed-off-by: Matthias Wessendorf <[email protected]> * use other image coordinates Signed-off-by: Matthias Wessendorf <[email protected]> * first test for source Signed-off-by: Matthias Wessendorf <[email protected]> * Adding initial rekt test Signed-off-by: Matthias Wessendorf <[email protected]> * Adding SSL support and test for IntegrationSource Signed-off-by: Matthias Wessendorf <[email protected]> * Formatting fixes Signed-off-by: Matthias Wessendorf <[email protected]> * Disable OIDC tests for now Signed-off-by: Matthias Wessendorf <[email protected]> * use knative nightly images Signed-off-by: Matthias Wessendorf <[email protected]> * Fixing linters Signed-off-by: Matthias Wessendorf <[email protected]> * addressing comments, Part1 Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Matthias Wessendorf <[email protected]> Co-authored-by: Pierangelo Di Pilato <[email protected]> * Add missing copyright boilerplate (knative#8305) :lipstick: add missing copyright boilerplate Signed-off-by: Matthias Wessendorf <[email protected]> * [chore] Use a generic access/secret key in the secret for AWS connections (knative#8312) :key: Use a generic access/secret key in the secret for AWS connections Signed-off-by: Matthias Wessendorf <[email protected]> * [chore] Do not generate SSL env vars for each struct entry, just once per containersource/image (knative#8315) :lipstick: Do not generate SSL env vars for each struct entry, just once per containersource/image Signed-off-by: Matthias Wessendorf <[email protected]> * Update Integration API and use custom tags on structs for better readability (knative#8321) Update API and use custom tags on structs Signed-off-by: Matthias Wessendorf <[email protected]> * Integration Api moved to versioned common (knative#8325) Moving API to a versioned common/integration folder Signed-off-by: Matthias Wessendorf <[email protected]> * Introducing common integration helper and change package name (knative#8327) * create new integration/source folder and factor common code into helper.go Signed-off-by: Matthias Wessendorf <[email protected]> * 💄 improve formatting... Signed-off-by: Matthias Wessendorf <[email protected]> * fixing import Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Matthias Wessendorf <[email protected]> * chore: correct comments (knative#8336) :lipstick: correct comments ... Signed-off-by: Matthias Wessendorf <[email protected]> * Add IntegrationSink CRD (knative#8304) * create new integration/source folder and factor common code into helper.go Signed-off-by: Matthias Wessendorf <[email protected]> * 💄 improve formatting... Signed-off-by: Matthias Wessendorf <[email protected]> * fixing import Signed-off-by: Matthias Wessendorf <[email protected]> * First Sink Signed-off-by: Matthias Wessendorf <[email protected]> * Updates on sink Signed-off-by: Matthias Wessendorf <[email protected]> * starting common types for source Signed-off-by: Matthias Wessendorf <[email protected]> * starting common types for sink Signed-off-by: Matthias Wessendorf <[email protected]> * some code share and refactorings * use other image coordinates Signed-off-by: Matthias Wessendorf <[email protected]> * Add missing api and tests for sink and run codegen Signed-off-by: Matthias Wessendorf <[email protected]> * Fixes Signed-off-by: Matthias Wessendorf <[email protected]> * Adding cert Signed-off-by: Matthias Wessendorf <[email protected]> * Adding test Signed-off-by: Matthias Wessendorf <[email protected]> * Rekt test for sink Signed-off-by: Matthias Wessendorf <[email protected]> * Rekt test for sink Signed-off-by: Matthias Wessendorf <[email protected]> * correct status code Signed-off-by: Matthias Wessendorf <[email protected]> * More... Signed-off-by: Matthias Wessendorf <[email protected]> * re-add service Signed-off-by: Matthias Wessendorf <[email protected]> * delete unversioned common api Signed-off-by: Matthias Wessendorf <[email protected]> * Updates, latest conflicts and formatting Clean ups Adding tests for reconciler Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Matthias Wessendorf <[email protected]> conflict Signed-off-by: Matthias Wessendorf <[email protected]> * IntegrationSink: rek-test templating support for bool annotations (knative#8342) bool annotations for represented as string, to avoid parsing errors Signed-off-by: Matthias Wessendorf <[email protected]> * Update integrationsink crd (knative#8347) * Align IntegrationSink CRD w/ IntegrationSource CRD Signed-off-by: Matthias Wessendorf <[email protected]> * 💄 Remove old job-sink references Signed-off-by: Matthias Wessendorf <[email protected]> * Docs change Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Matthias Wessendorf <[email protected]> * Avoid using twice hardcoded strings for the names of the Kube Secret keys, for AWS access/secret key vals (knative#8345) :lipstick: Avoid using twice hardcoded strings for the names of the Kubescret keys, for AWS access/secret key vals Signed-off-by: Matthias Wessendorf <[email protected]> * Add integrationsinks-addressable-resolver cluster role (knative#8356) :passport_control: Add integrationsinks-addressable-resolver cluster role Signed-off-by: Matthias Wessendorf <[email protected]> * Align label generation and apply on container-source as well (knative#8355) Signed-off-by: Matthias Wessendorf <[email protected]> * We changed the event type on the images (knative#8364) :fire: We changed the event type on the images Signed-off-by: Matthias Wessendorf <[email protected]> * Move image to map (knative#8362) Signed-off-by: Matthias Wessendorf <[email protected]> * Adding sns sink to Integration Sink (knative#8365) adding sns sink Signed-off-by: Matthias Wessendorf <[email protected]> * Clean up remove session token (knative#8369) Remove session token and profile credential name Signed-off-by: Matthias Wessendorf <[email protected]> * Chore: field semantic correction (knative#8370) :lipstick: We renamed those fields to , and we reflect that now in validation Signed-off-by: Matthias Wessendorf <[email protected]> * Remove unused filter function (knative#8375) :broom: Remove unused filter function Signed-off-by: Matthias Wessendorf <[email protected]> * add new integration CRDs to storage version migrator tool (knative#8386) Signed-off-by: Matthias Wessendorf <[email protected]> * Going OIDC for Integration Source (knative#8383) Going OIDC for Integration Source: - Generating OIDC specific evn_vars for Knative client of camel - Adding rekt-test for OIDC feature of the source Signed-off-by: Matthias Wessendorf <[email protected]> * Adding reconciler test for OIDC of the Integration Source (knative#8404) Signed-off-by: Matthias Wessendorf <[email protected]> * Not just render oidc env-vars when cfg is on, we need also a present audience to ensure the camel containers work correct (knative#8448) Signed-off-by: Matthias Wessendorf <[email protected]> * run `make generate-release` --------- Signed-off-by: Matthias Wessendorf <[email protected]> Co-authored-by: Pierangelo Di Pilato <[email protected]> Co-authored-by: Christoph Stäbler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Pre-review Checklist
Release Note
Docs