Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add health check config and clean up duplicated code #8308

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Add health check config and clean up duplicated code #8308

merged 6 commits into from
Dec 11, 2024

Conversation

airycanon
Copy link
Contributor

Fixes #8192

Proposed Changes

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@knative-prow knative-prow bot requested review from Cali0707 and pierDipi November 6, 2024 02:25
@airycanon airycanon changed the title Add health check configs and clean up duplicated code Add health check config and clean up duplicated code Nov 6, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 6, 2024

Welcome @airycanon! It looks like this is your first PR to knative/eventing 🎉

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 6, 2024

Hi @airycanon. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2024
@Cali0707
Copy link
Member

Cali0707 commented Nov 6, 2024

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2024
@airycanon
Copy link
Contributor Author

/retest-required

@pierDipi
Copy link
Member

@airycanon failures seems related, adapter package is used also by ApiServerSource

@airycanon
Copy link
Contributor Author

airycanon commented Dec 5, 2024 •
edited
Loading

@pierDipi thanks for your guidance, I have fixed the failed tests, would you mind taking another look?

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2024
pierDipi
pierDipi approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2024
@pierDipi
Copy link
Member

Thanks @airycanon

@airycanon
Copy link
Contributor Author

/retest

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
pierDipi
pierDipi approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: airycanon, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7c1a62d into knative:main Dec 11, 2024
7 checks passed
creydr pushed a commit to creydr/knative-eventing that referenced this pull request Feb 5, 2025
@airycanon @creydr
Add health check config and clean up duplicated code (knative#8308)
60d03cb 
* Remove the duplicated health check

* Add the missing health check config

* Add the missing health check

* Remove the duplicated health check

* Fix non-blocking test

* Fix receive adapter probes path
openshift-merge-bot bot pushed a commit to openshift-knative/eventing that referenced this pull request Feb 6, 2025
@creydr @airycanon
[release-v1.16] Add health check config and clean up duplicated code (k…
e230f19 
…native#8308) (#1059)

* Add health check config and clean up duplicated code (knative#8308)

* Remove the duplicated health check

* Add the missing health check config

* Add the missing health check

* Remove the duplicated health check

* Fix non-blocking test

* Fix receive adapter probes path

* run `make generate-release`

---------

Co-authored-by: Yukun Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@Cali0707 Cali0707 Awaiting requested review from Cali0707

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add readiness and liveness probes in pingsource-mt-adapter
3 participants
@airycanon @Cali0707 @pierDipi