Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] AWS APIs to a common package #8306

Closed

Conversation

matzew
Copy link
Member

@matzew matzew commented Nov 5, 2024

Proposed Changes

  • some "pre factoring" to move the AWS types into a common package, before we add the IntegrationSink, and avoid "complex" refactoring while also adding the new sink.

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot requested review from aliok and aslom November 5, 2024 14:20
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.57%. Comparing base (3f2b75b) to head (079b7e5).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/apis/common/aws.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8306      +/-   ##
==========================================
- Coverage   64.58%   64.57%   -0.01%     
==========================================
  Files         373      374       +1     
  Lines       22619    22622       +3     
==========================================
  Hits        14609    14609              
- Misses       7244     7247       +3     
  Partials      766      766              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Matthias Wessendorf <[email protected]>
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
Copy link

knative-prow bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
@matzew
Copy link
Member Author

matzew commented Nov 13, 2024

/close

based on the feedback I have opened two separate PRs for the discussed bits here

@knative-prow knative-prow bot closed this Nov 13, 2024
Copy link

knative-prow bot commented Nov 13, 2024

@matzew: Closed this PR.

In response to this:

/close

based on the feedback I have opened two separate PRs for the discussed bits here

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants