-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] AWS APIs to a common package #8306
Conversation
Signed-off-by: Matthias Wessendorf <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8306 +/- ##
==========================================
- Coverage 64.58% 64.57% -0.01%
==========================================
Files 373 374 +1
Lines 22619 22622 +3
==========================================
Hits 14609 14609
- Misses 7244 7247 +3
Partials 766 766 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matthias Wessendorf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/close based on the feedback I have opened two separate PRs for the discussed bits here |
@matzew: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Proposed Changes
IntegrationSink
, and avoid "complex" refactoring while also adding the new sink.Pre-review Checklist
Release Note
Docs