-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IntegrationSink CRD #8304
Merged
knative-prow
merged 20 commits into
knative:main
from
matzew:add_integration_sink_rework
Nov 22, 2024
Merged
Add IntegrationSink CRD #8304
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
300a61d
create new integration/source folder and factor common code into help…
matzew 2d845b2
:lipstick: improve formatting...
matzew c3ac1e4
fixing import
matzew 197234b
First Sink
matzew f2dc48d
Updates on sink
matzew 3b883f5
starting common types for source
matzew 6f775fc
starting common types for sink
matzew 20caae3
some code share and refactorings
matzew 0f1f1a8
use other image coordinates
matzew 606f9b4
Add missing api and tests for sink and run codegen
matzew 98a9ef0
Fixes
matzew c11e7de
Adding cert
matzew e3456c3
Adding test
matzew 2d01633
Rekt test for sink
matzew f33a0a6
Rekt test for sink
matzew eda174e
correct status code
matzew 27e7ad0
More...
matzew f9d1708
re-add service
matzew 22be4dd
delete unversioned common api
matzew 9d7e051
Updates, latest conflicts and formatting
matzew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
core/resources/integrationsink.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Copyright 2023 The Knative Authors | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
apiVersion: cert-manager.io/v1 | ||
kind: Certificate | ||
metadata: | ||
name: integration-sink-server-tls | ||
namespace: knative-eventing | ||
spec: | ||
# Secret names are always required. | ||
secretName: integration-sink-server-tls | ||
|
||
secretTemplate: | ||
labels: | ||
app.kubernetes.io/component: integration-sink | ||
app.kubernetes.io/name: knative-eventing | ||
|
||
# Use 0m0s so that we don't run into https://github.com/cert-manager/cert-manager/issues/6408 on the operator | ||
duration: 2160h0m0s # 90d | ||
renewBefore: 360h0m0s # 15d | ||
subject: | ||
organizations: | ||
- local | ||
privateKey: | ||
algorithm: RSA | ||
encoding: PKCS1 | ||
size: 2048 | ||
rotationPolicy: Always | ||
|
||
dnsNames: | ||
- integration-sink.knative-eventing.svc.cluster.local | ||
- integration-sink.knative-eventing.svc | ||
|
||
issuerRef: | ||
name: knative-eventing-ca-issuer | ||
kind: ClusterIssuer | ||
group: cert-manager.io |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are actually not using this.
In a follow up PR, we will generate these
Certificate
manifest for eachIntegrationSource
instance (theirService
).