Use GetServiceHostname when passing URL to JobSink #8303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using Knative Service as the sink simply by adding an option to enviroment: eventshub.WithKnativeServiceForwarder
knative-prow
bot
added
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8303 +/- ##
=======================================
Coverage 64.58% 64.58%
=======================================
Files 373 373
Lines 22619 22619
=======================================
Hits 14609 14609
Misses 7244 7244
Partials 766 766 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
mgencur
added a commit
to mgencur/eventing
that referenced
this pull request
Nov 5, 2024
This allows using Knative Service as the sink simply by adding an option to enviroment: eventshub.WithKnativeServiceForwarder
pierDipi
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Nov 5, 2024
This allows using Knative Service as the sink simply by adding an option to enviroment: eventshub.WithKnativeServiceForwarder
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/knative-eventing
that referenced
this pull request
Nov 5, 2024
This allows using Knative Service as the sink simply by adding an option to enviroment: eventshub.WithKnativeServiceForwarder
pierDipi
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Nov 5, 2024
This allows using Knative Service as the sink simply by adding an option to enviroment: eventshub.WithKnativeServiceForwarder Co-authored-by: Martin Gencur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using Knative Service as the sink in tests simply by adding an option to enviroment for reconciler-test: eventshub.WithKnativeServiceForwarder.
The URL will change from
http://sink-jouanbaftohttp://sink-jouanbaf.test-ynyxtcbf.svc.cluster.localin most cases.Before this change, the sender was getting 404.
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs