Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] Add jobsinks-addressable-resolver cluster role #8302

Commits on Nov 4, 2024

  1. Add jobsinks-addressable-resolver cluster role

    This will ensure that alld ServiceAccount that are bound to
    "addressable-resolver" ClusterRole can read JobSinks.
    
    Fixes issues like this for SinkBindings:
    ```
    {"level":"error","ts":"2024-11-04T08:06:16.160Z","logger":"eventing-webhook","caller":"sinkbinding/sinkbinding.go:87",
    "msg":"Failed to get Addressable from Destination:
    %!w(*fmt.wrapError=&{failed to get lister for
    sinks.knative.dev/v1alpha1,
    Resource=jobsinks: jobsinks.sinks.knative.dev is forbidden:
    User \"system:serviceaccount:knative-eventing:eventing-webhook\"
    cannot list resource \"jobsinks\" in API group \"sinks.knative.dev\"
    ```
    mgencur authored and knative-prow-robot committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b282b83 View commit details
    Browse the repository at this point in the history