Add jobsinks-addressable-resolver cluster role #8298
Conversation
This will ensure that alld ServiceAccount that are bound to
"addressable-resolver" ClusterRole can read JobSinks.
Fixes issues like this for SinkBindings:
```
{"level":"error","ts":"2024-11-04T08:06:16.160Z","logger":"eventing-webhook","caller":"sinkbinding/sinkbinding.go:87",
"msg":"Failed to get Addressable from Destination:
%!w(*fmt.wrapError=&{failed to get lister for
sinks.knative.dev/v1alpha1,
Resource=jobsinks: jobsinks.sinks.knative.dev is forbidden:
User \"system:serviceaccount:knative-eventing:eventing-webhook\"
cannot list resource \"jobsinks\" in API group \"sinks.knative.dev\"
```
knative-prow
bot
added
the
size/M
|
/cherry-pick release-1.16 |
|
@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8298 +/- ##
=======================================
Coverage 64.58% 64.58%
=======================================
Files 373 373
Lines 22619 22619
=======================================
Hits 14609 14609
Misses 7244 7244
Partials 766 766 ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-1.15 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
@pierDipi: new pull request created: #8301 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@mgencur: new pull request created: #8302 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This will ensure that all ServiceAccounts that are bound to "addressable-resolver" ClusterRole can read JobSinks.
This replaces 2e4d353 because it's more general. The fix was suggested in PR for Eventing Kafka Broker
Fixes also issues like this for SinkBindings:
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs