Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update jobsink TLS comments #8215

Merged
merged 1 commit into from
Oct 2, 2024
Merged

update jobsink TLS comments #8215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/reconciler/jobsink/jobsink.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, js *sinks.JobSink) recon
}

func (r *Reconciler) getCaCerts() (*string, error) {
// Getting the secret called "imc-dispatcher-tls" from system namespace
// Getting the secret called "job-sink-server-tls" from system namespace
secret, err := r.secretLister.Secrets(r.systemNamespace).Get(eventingtls.JobSinkDispatcherServerTLSSecretName)
if err != nil {
return nil, fmt.Errorf("failed to get CA certs from %s/%s: %w", r.systemNamespace, eventingtls.JobSinkDispatcherServerTLSSecretName, err)
Expand Down Expand Up @@ -119,7 +119,7 @@ func (r *Reconciler) reconcileAddress(ctx context.Context, js *sinks.JobSink) er
js.Status.Addresses[i].Audience = &audience
}
} else {
logging.FromContext(ctx).Debug("Clearing the imc audience as OIDC is not enabled")
logging.FromContext(ctx).Debug("Clearing the JobSink audience as OIDC is not enabled")
js.Status.Address.Audience = nil
for i := range js.Status.Addresses {
js.Status.Addresses[i].Audience = nil
Expand Down
Loading