Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Format Go code #7206

Merged

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/eventing-writers
/assign knative/eventing-writers

Produced by: knative-extensions/knobots/actions/update-gofmt

Details:

 

@knative-prow knative-prow bot requested a review from a team August 25, 2023 01:25
@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (25f7e03) 77.87% compared to head (d6094d2) 77.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7206      +/-   ##
==========================================
+ Coverage   77.87%   77.89%   +0.02%     
==========================================
  Files         246      246              
  Lines       13214    13214              
==========================================
+ Hits        10290    10293       +3     
+ Misses       2402     2400       -2     
+ Partials      522      521       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@Cali0707
Copy link
Member

/cc @matzew @pierDipi

@knative-prow knative-prow bot requested review from matzew and pierDipi August 25, 2023 13:51
Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, knative-automation, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@knative-prow knative-prow bot merged commit d547e2d into knative:main Aug 28, 2023
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants