[release-v1.11] Cherry pick eventtype autocreate fixes #7201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed undefined typemeta on broker in eventtype autocreate Signed-off-by: Calum Murray <[email protected]> * Fixed autocreate so that only one eventtype is created when events are sent to mt channel broker Signed-off-by: Calum Murray <[email protected]> * Clean up Signed-off-by: Calum Murray <[email protected]> * Fixed unit tests Signed-off-by: Calum Murray <[email protected]> * channel only creates eventtypes if not owned by broker Signed-off-by: Calum Murray <[email protected]> --------- Signed-off-by: Calum Murray <[email protected]>
|
/cc @matzew |
knative-prow
bot
added
the
size/M
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.11 #7201 +/- ##
================================================
- Coverage 78.05% 77.95% -0.10%
================================================
Files 250 250
Lines 13402 13419 +17
================================================
Hits 10461 10461
- Misses 2407 2422 +15
- Partials 534 536 +2
☔ View full report in Codecov by Sentry. |
matzew
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/test upgrade-tests |
|
@Cali0707 thanks dude! |
knative-prow
bot
merged commit 3ccfc1c
into
knative:release-1.11
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry pick of #7161 onto release-1.11