Added rekt test for channel event autocreate #7198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <[email protected]>
knative-prow
bot
added
area/test-and-release
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7198 +/- ##
==========================================
- Coverage 77.95% 77.90% -0.05%
==========================================
Files 246 246
Lines 13202 13202
==========================================
- Hits 10291 10285 -6
- Misses 2390 2394 +4
- Partials 521 523 +2 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/test upgrade-tests |
mgencur
pushed a commit
to mgencur/eventing
that referenced
this pull request
Jan 24, 2024
Signed-off-by: Calum Murray <[email protected]>
mgencur
pushed a commit
to mgencur/eventing
that referenced
this pull request
Jan 29, 2024
Signed-off-by: Calum Murray <[email protected]>
openshift-merge-bot bot
pushed a commit
to openshift-knative/eventing
that referenced
this pull request
Jan 29, 2024
* Added rekt test for channel event autocreate (knative#7198) Signed-off-by: Calum Murray <[email protected]> * Move eventtype rekttest pingsource to experiment (knative#7180) * Fix the merge conflict and fix the logical error in the test Signed-off-by: Leo Li <[email protected]> * Add the auto eventType creation support Signed-off-by: Leo Li <[email protected]> * reformat and remove the comments Signed-off-by: Leo Li <[email protected]> * Remove the assertReference function Signed-off-by: Leo Li <[email protected]> * fix reviewDog issue Signed-off-by: Leo Li <[email protected]> * Update test/rekt/resources/eventtype/eventtype.go Co-authored-by: Calum Murray <[email protected]> * fix reviewDog issue Signed-off-by: Leo Li <[email protected]> * Move the test to experimental rekt Signed-off-by: Leo Li <[email protected]> * Remove the eventtype test from the pingsource rekt test Signed-off-by: Leo Li <[email protected]> * Rename the test name to make it more intuitive Signed-off-by: Leo Li <[email protected]> * Revert the unit test change Signed-off-by: Leo Li <[email protected]> * Format fix Signed-off-by: Leo Li <[email protected]> * format fix Signed-off-by: Leo Li <[email protected]> * Fix Christoph's comment Signed-off-by: Leo Li <[email protected]> * go imports Signed-off-by: Leo Li <[email protected]> * Update test/experimental/features/eventtype_autocreation/eventtype.go Co-authored-by: Christoph Stäbler <[email protected]> * Update test/experimental/eventtype_autocreation_test.go Co-authored-by: Christoph Stäbler <[email protected]> * Apply suggestions from code review Co-authored-by: Christoph Stäbler <[email protected]> * Change the name of the file Signed-off-by: Leo Li <[email protected]> * Update the deprecated string Signed-off-by: Leo Li <[email protected]> * Update test/rekt/features/pingsource/features.go Co-authored-by: Calum Murray <[email protected]> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <[email protected]> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <[email protected]> --------- Signed-off-by: Leo Li <[email protected]> Co-authored-by: Calum Murray <[email protected]> Co-authored-by: Christoph Stäbler <[email protected]> Co-authored-by: Matthias Wessendorf <[email protected]> * Added rekt test for broker eventtype autocreate (knative#7202) Signed-off-by: Calum Murray <[email protected]> * change the deprecated string (knative#7179) * change the deprecated string * Apply suggestions from code review Co-authored-by: Calum Murray <[email protected]> --------- Co-authored-by: Calum Murray <[email protected]> * rekt test to verify only one EventType created for MTBroker (knative#7586) fix: eventtype autocreate for broker asserts that only one et is created Signed-off-by: Calum Murray <[email protected]> * Generalize description of EventType in CRD. (knative#7617) Generalize description of EventType. EventType is now compatible with other resources as well, not just Broker. * Scripts for executing experimental reconciler tests * Revert "change the deprecated string (knative#7179)" This reverts commit 7659227. * Revert "Move eventtype rekttest pingsource to experiment (knative#7180)" This reverts commit c8d12c3. * Revert "rekt test to verify only one EventType created for MTBroker (knative#7586)" This reverts commit 4eac230. * Revert "Revert "change the deprecated string (knative#7179)"" This reverts commit e469414. * Use sources.ApiServerSourceEventResourceModeTypes for ApiServerSource * Clean up imports --------- Signed-off-by: Calum Murray <[email protected]> Signed-off-by: Leo Li <[email protected]> Co-authored-by: Calum Murray <[email protected]> Co-authored-by: Leo Li <[email protected]> Co-authored-by: Christoph Stäbler <[email protected]> Co-authored-by: Matthias Wessendorf <[email protected]> Co-authored-by: Iqbal H <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7197
Proposed Changes
Pre-review Checklist