Move eventtype rekttest pingsource to experiment #7180

Leo6Leo · 2023-08-15T18:21:12Z

Fixes #7181

Proposed Changes

As per discussion here, will move this experimental test to the experiment rekt test folder.

Pre-review Checklist

At least 80% unit test coverage
E2E tests for any new behavior
Docs PR for any user-facing impact
Spec PR for any new API feature
Conformance test for any change to the spec

Release Note

Docs

Signed-off-by: Leo Li <[email protected]>

Co-authored-by: Calum Murray <[email protected]>

Signed-off-by: Leo Li <[email protected]>

codecov · 2023-08-15T18:32:49Z

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (08cf00f) 77.89% compared to head (8981098) 77.87%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7180      +/-   ##
==========================================
- Coverage   77.89%   77.87%   -0.03%     
==========================================
  Files         246      246              
  Lines       13214    13214              
==========================================
- Hits        10293    10290       -3     
- Misses       2400     2402       +2     
- Partials      521      522       +1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Leo Li <[email protected]>

Cali0707 · 2023-08-15T19:03:31Z

@Leo6Leo should we hold on #7166 until after this is merged?

knative-prow · 2023-08-15T19:20:11Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: Leo Li <[email protected]>

Leo6Leo · 2023-08-15T21:47:04Z

/cc @creydr @Cali0707

matzew · 2023-08-24T09:10:26Z

/retest

matzew · 2023-08-24T09:59:00Z

/test upgrade-tests

matzew · 2023-08-24T12:32:11Z

@Leo6Leo this needs a rebase

Signed-off-by: Leo Li <[email protected]>

…ce-to-experiment' into move-eventtype-rekttest-pingsource-to-experiment

matzew

/lgtm
/unhold

Signed-off-by: Leo Li <[email protected]>

Leo6Leo · 2023-08-24T18:31:34Z

/cc @Cali0707 @matzew

Cali0707

/lgtm

Thanks @Leo6Leo !

knative-prow · 2023-08-24T18:37:59Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, Leo6Leo, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/OWNERS~~ [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Leo6Leo · 2023-08-24T19:03:57Z

/retest-required

* Fix the merge conflict and fix the logical error in the test Signed-off-by: Leo Li <[email protected]> * Add the auto eventType creation support Signed-off-by: Leo Li <[email protected]> * reformat and remove the comments Signed-off-by: Leo Li <[email protected]> * Remove the assertReference function Signed-off-by: Leo Li <[email protected]> * fix reviewDog issue Signed-off-by: Leo Li <[email protected]> * Update test/rekt/resources/eventtype/eventtype.go Co-authored-by: Calum Murray <[email protected]> * fix reviewDog issue Signed-off-by: Leo Li <[email protected]> * Move the test to experimental rekt Signed-off-by: Leo Li <[email protected]> * Remove the eventtype test from the pingsource rekt test Signed-off-by: Leo Li <[email protected]> * Rename the test name to make it more intuitive Signed-off-by: Leo Li <[email protected]> * Revert the unit test change Signed-off-by: Leo Li <[email protected]> * Format fix Signed-off-by: Leo Li <[email protected]> * format fix Signed-off-by: Leo Li <[email protected]> * Fix Christoph's comment Signed-off-by: Leo Li <[email protected]> * go imports Signed-off-by: Leo Li <[email protected]> * Update test/experimental/features/eventtype_autocreation/eventtype.go Co-authored-by: Christoph Stäbler <[email protected]> * Update test/experimental/eventtype_autocreation_test.go Co-authored-by: Christoph Stäbler <[email protected]> * Apply suggestions from code review Co-authored-by: Christoph Stäbler <[email protected]> * Change the name of the file Signed-off-by: Leo Li <[email protected]> * Update the deprecated string Signed-off-by: Leo Li <[email protected]> * Update test/rekt/features/pingsource/features.go Co-authored-by: Calum Murray <[email protected]> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <[email protected]> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <[email protected]> --------- Signed-off-by: Leo Li <[email protected]> Co-authored-by: Calum Murray <[email protected]> Co-authored-by: Christoph Stäbler <[email protected]> Co-authored-by: Matthias Wessendorf <[email protected]>

This reverts commit c8d12c3.

* Fix the merge conflict and fix the logical error in the test Signed-off-by: Leo Li <[email protected]> * Add the auto eventType creation support Signed-off-by: Leo Li <[email protected]> * reformat and remove the comments Signed-off-by: Leo Li <[email protected]> * Remove the assertReference function Signed-off-by: Leo Li <[email protected]> * fix reviewDog issue Signed-off-by: Leo Li <[email protected]> * Update test/rekt/resources/eventtype/eventtype.go Co-authored-by: Calum Murray <[email protected]> * fix reviewDog issue Signed-off-by: Leo Li <[email protected]> * Move the test to experimental rekt Signed-off-by: Leo Li <[email protected]> * Remove the eventtype test from the pingsource rekt test Signed-off-by: Leo Li <[email protected]> * Rename the test name to make it more intuitive Signed-off-by: Leo Li <[email protected]> * Revert the unit test change Signed-off-by: Leo Li <[email protected]> * Format fix Signed-off-by: Leo Li <[email protected]> * format fix Signed-off-by: Leo Li <[email protected]> * Fix Christoph's comment Signed-off-by: Leo Li <[email protected]> * go imports Signed-off-by: Leo Li <[email protected]> * Update test/experimental/features/eventtype_autocreation/eventtype.go Co-authored-by: Christoph Stäbler <[email protected]> * Update test/experimental/eventtype_autocreation_test.go Co-authored-by: Christoph Stäbler <[email protected]> * Apply suggestions from code review Co-authored-by: Christoph Stäbler <[email protected]> * Change the name of the file Signed-off-by: Leo Li <[email protected]> * Update the deprecated string Signed-off-by: Leo Li <[email protected]> * Update test/rekt/features/pingsource/features.go Co-authored-by: Calum Murray <[email protected]> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <[email protected]> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <[email protected]> --------- Signed-off-by: Leo Li <[email protected]> Co-authored-by: Calum Murray <[email protected]> Co-authored-by: Christoph Stäbler <[email protected]> Co-authored-by: Matthias Wessendorf <[email protected]>

This reverts commit c8d12c3.

* Added rekt test for channel event autocreate (knative#7198) Signed-off-by: Calum Murray <[email protected]> * Move eventtype rekttest pingsource to experiment (knative#7180) * Fix the merge conflict and fix the logical error in the test Signed-off-by: Leo Li <[email protected]> * Add the auto eventType creation support Signed-off-by: Leo Li <[email protected]> * reformat and remove the comments Signed-off-by: Leo Li <[email protected]> * Remove the assertReference function Signed-off-by: Leo Li <[email protected]> * fix reviewDog issue Signed-off-by: Leo Li <[email protected]> * Update test/rekt/resources/eventtype/eventtype.go Co-authored-by: Calum Murray <[email protected]> * fix reviewDog issue Signed-off-by: Leo Li <[email protected]> * Move the test to experimental rekt Signed-off-by: Leo Li <[email protected]> * Remove the eventtype test from the pingsource rekt test Signed-off-by: Leo Li <[email protected]> * Rename the test name to make it more intuitive Signed-off-by: Leo Li <[email protected]> * Revert the unit test change Signed-off-by: Leo Li <[email protected]> * Format fix Signed-off-by: Leo Li <[email protected]> * format fix Signed-off-by: Leo Li <[email protected]> * Fix Christoph's comment Signed-off-by: Leo Li <[email protected]> * go imports Signed-off-by: Leo Li <[email protected]> * Update test/experimental/features/eventtype_autocreation/eventtype.go Co-authored-by: Christoph Stäbler <[email protected]> * Update test/experimental/eventtype_autocreation_test.go Co-authored-by: Christoph Stäbler <[email protected]> * Apply suggestions from code review Co-authored-by: Christoph Stäbler <[email protected]> * Change the name of the file Signed-off-by: Leo Li <[email protected]> * Update the deprecated string Signed-off-by: Leo Li <[email protected]> * Update test/rekt/features/pingsource/features.go Co-authored-by: Calum Murray <[email protected]> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <[email protected]> * Manually merge the chanhges from Calum's ticket Signed-off-by: Leo Li <[email protected]> --------- Signed-off-by: Leo Li <[email protected]> Co-authored-by: Calum Murray <[email protected]> Co-authored-by: Christoph Stäbler <[email protected]> Co-authored-by: Matthias Wessendorf <[email protected]> * Added rekt test for broker eventtype autocreate (knative#7202) Signed-off-by: Calum Murray <[email protected]> * change the deprecated string (knative#7179) * change the deprecated string * Apply suggestions from code review Co-authored-by: Calum Murray <[email protected]> --------- Co-authored-by: Calum Murray <[email protected]> * rekt test to verify only one EventType created for MTBroker (knative#7586) fix: eventtype autocreate for broker asserts that only one et is created Signed-off-by: Calum Murray <[email protected]> * Generalize description of EventType in CRD. (knative#7617) Generalize description of EventType. EventType is now compatible with other resources as well, not just Broker. * Scripts for executing experimental reconciler tests * Revert "change the deprecated string (knative#7179)" This reverts commit 7659227. * Revert "Move eventtype rekttest pingsource to experiment (knative#7180)" This reverts commit c8d12c3. * Revert "rekt test to verify only one EventType created for MTBroker (knative#7586)" This reverts commit 4eac230. * Revert "Revert "change the deprecated string (knative#7179)"" This reverts commit e469414. * Use sources.ApiServerSourceEventResourceModeTypes for ApiServerSource * Clean up imports --------- Signed-off-by: Calum Murray <[email protected]> Signed-off-by: Leo Li <[email protected]> Co-authored-by: Calum Murray <[email protected]> Co-authored-by: Leo Li <[email protected]> Co-authored-by: Christoph Stäbler <[email protected]> Co-authored-by: Matthias Wessendorf <[email protected]> Co-authored-by: Iqbal H <[email protected]>

Leo6Leo and others added 10 commits August 10, 2023 13:19

Fix the merge conflict and fix the logical error in the test

c77ee3d

Signed-off-by: Leo Li <[email protected]>

Add the auto eventType creation support

605a337

Signed-off-by: Leo Li <[email protected]>

reformat and remove the comments

cd60211

Signed-off-by: Leo Li <[email protected]>

Remove the assertReference function

e58d700

Signed-off-by: Leo Li <[email protected]>

fix reviewDog issue

adcdff7

Signed-off-by: Leo Li <[email protected]>

Update test/rekt/resources/eventtype/eventtype.go

8e4150e

Co-authored-by: Calum Murray <[email protected]>

fix reviewDog issue

9a4200e

Signed-off-by: Leo Li <[email protected]>

Merge branch 'main' into eventType-test-logical-error

5783715

Merge branch 'main' into eventType-test-logical-error

a700867

Move the test to experimental rekt

899fbfa

Signed-off-by: Leo Li <[email protected]>

Leo6Leo added 4 commits August 15, 2023 14:47

Remove the eventtype test from the pingsource rekt test

edaeca3

Signed-off-by: Leo Li <[email protected]>

Rename the test name to make it more intuitive

20a0632

Signed-off-by: Leo Li <[email protected]>

Revert the unit test change

f73d7bd

Signed-off-by: Leo Li <[email protected]>

Format fix

13b2b6f

Signed-off-by: Leo Li <[email protected]>

Leo6Leo mentioned this pull request Aug 15, 2023

[WIP] Add reconciler test for EventType references #7114

Closed

5 tasks

knative-prow bot added area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 15, 2023

knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2023

knative-prow bot requested review from evankanderson and mgencur August 15, 2023 19:20

Leo6Leo marked this pull request as ready for review August 15, 2023 19:37

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 15, 2023

format fix

3facd48

Signed-off-by: Leo Li <[email protected]>

knative-prow bot requested review from Cali0707 and creydr August 15, 2023 21:47

creydr mentioned this pull request Aug 16, 2023

Event type test logical error #7166

Merged

5 tasks

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2023

Leo6Leo added 2 commits August 24, 2023 14:13

Merge the main branch

2f7d667

Signed-off-by: Leo Li <[email protected]>

Merge remote-tracking branch 'origin/move-eventtype-rekttest-pingsour…

286bdcc

…ce-to-experiment' into move-eventtype-rekttest-pingsource-to-experiment

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2023

matzew approved these changes Aug 24, 2023

View reviewed changes

knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 24, 2023

Manually merge the chanhges from Calum's ticket

c65e276

Signed-off-by: Leo Li <[email protected]>

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023

Manually merge the chanhges from Calum's ticket

8981098

Signed-off-by: Leo Li <[email protected]>

knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2023

knative-prow bot requested review from Cali0707 and matzew August 24, 2023 18:31

Cali0707 approved these changes Aug 24, 2023

View reviewed changes

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2023

knative-prow bot merged commit 0e8b7ca into knative:main Aug 24, 2023

creydr mentioned this pull request Sep 6, 2023

Remove submodule patch to skip pingsource event type test openshift-knative/eventing-istio#62

Merged

mgencur added a commit to mgencur/eventing that referenced this pull request Jan 25, 2024

Revert "Move eventtype rekttest pingsource to experiment (knative#7180)"

f150201

This reverts commit c8d12c3.

mgencur added a commit to mgencur/eventing that referenced this pull request Jan 29, 2024

Revert "Move eventtype rekttest pingsource to experiment (knative#7180)"

1249a5b

This reverts commit c8d12c3.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move eventtype rekttest pingsource to experiment #7180

Move eventtype rekttest pingsource to experiment #7180

Leo6Leo commented Aug 15, 2023 •

edited

Loading

codecov bot commented Aug 15, 2023 •

edited

Loading

Cali0707 commented Aug 15, 2023

knative-prow bot commented Aug 15, 2023

Leo6Leo commented Aug 15, 2023

matzew commented Aug 24, 2023

matzew commented Aug 24, 2023

matzew commented Aug 24, 2023

matzew left a comment

Leo6Leo commented Aug 24, 2023

Cali0707 left a comment

knative-prow bot commented Aug 24, 2023

Leo6Leo commented Aug 24, 2023

Move eventtype rekttest pingsource to experiment #7180

Move eventtype rekttest pingsource to experiment #7180

Conversation

Leo6Leo commented Aug 15, 2023 • edited Loading

Proposed Changes

Pre-review Checklist

codecov bot commented Aug 15, 2023 • edited Loading

Codecov Report

Cali0707 commented Aug 15, 2023

knative-prow bot commented Aug 15, 2023

Leo6Leo commented Aug 15, 2023

matzew commented Aug 24, 2023

matzew commented Aug 24, 2023

matzew commented Aug 24, 2023

matzew left a comment

Choose a reason for hiding this comment

Leo6Leo commented Aug 24, 2023

Cali0707 left a comment

Choose a reason for hiding this comment

knative-prow bot commented Aug 24, 2023

Leo6Leo commented Aug 24, 2023

Leo6Leo commented Aug 15, 2023 •

edited

Loading

codecov bot commented Aug 15, 2023 •

edited

Loading