Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the button border radius on Tutorial page #6064 #6070

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

rissh
Copy link
Contributor

@rissh rissh commented Jul 22, 2024

Fixes #6064

This PR updates the border radius of the "Get started" buttons on the Tutorial page to match the border radius used on the home page.

Proposed Changes

  • Applied border-radius: 0.7rem; to the "Get started" buttons on the Tutorial page.

Additional Context

  • The home page uses border-radius: 0.7rem; for its buttons, and this change ensures consistency in the button styles across the website.

Copy link

linux-foundation-easycla bot commented Jul 22, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Jul 22, 2024

Welcome @rissh! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 22, 2024
@knative-prow knative-prow bot requested review from Cali0707 and nainaz July 22, 2024 18:44
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit df017de
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/669ea88e66e7e60008903944
😎 Deploy Preview https://deploy-preview-6070--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Adding some other UX folks here to give another look at it
/cc @mmejia02 @zainabhusain227 @Leo6Leo

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
@Leo6Leo
Copy link
Member

Leo6Leo commented Jul 22, 2024

It looks great!
/approve
Thanks for the quick action! @rissh

Copy link

knative-prow bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, rissh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2024
@knative-prow knative-prow bot merged commit 7129b49 into knative:main Jul 22, 2024
19 checks passed
@rissh
Copy link
Contributor Author

rissh commented Jul 23, 2024

It looks great! /approve Thanks for the quick action! @rissh

Hey @everyone,

It was great working here and I am looking forward to contributing in the future.

@Leo6Leo
Copy link
Member

Leo6Leo commented Jul 23, 2024

Hi @rissh, Just a friendly note that you may want to note about the use of @everyone here. GitHub doesn't actually support mentioning all contributors who are involved this way. Instead, @everyone would ping a specific user with that username ;)

For future reference, you can mention specific team members or use other GitHub features to notify relevant people about the PR. You may find this helpful to your journey in the open source contribution!

Again thanks for your contributions to Knative!

@rissh
Copy link
Contributor Author

rissh commented Jul 23, 2024

Hi @rissh, Just a friendly note that you may want to note about the use of @everyone here. GitHub doesn't actually support mentioning all contributors who are involved this way. Instead, @everyone would ping a specific user with that username ;)

For future reference, you can mention specific team members or use other GitHub features to notify relevant people about the PR. You may find this helpful to your journey in the open source contribution!

Again thanks for your contributions to Knative!

Hey @Leo6Leo, thanks for the reminder. I knew about it but forgot about it this time.

PS: Habit of using Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the button border radius on Tutorial page
3 participants