-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the button border radius on Tutorial page #6064 #6070
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @rissh! It looks like this is your first PR to knative/docs 🎉 |
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Adding some other UX folks here to give another look at it
/cc @mmejia02 @zainabhusain227 @Leo6Leo
It looks great! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo, rissh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @rissh, Just a friendly note that you may want to note about the use of For future reference, you can mention specific team members or use other GitHub features to notify relevant people about the PR. You may find this helpful to your journey in the open source contribution! Again thanks for your contributions to Knative! |
Hey @Leo6Leo, thanks for the reminder. I knew about it but forgot about it this time. PS: Habit of using Slack |
Fixes #6064
This PR updates the border radius of the "Get started" buttons on the Tutorial page to match the border radius used on the home page.
Proposed Changes
border-radius: 0.7rem;
to the "Get started" buttons on the Tutorial page.Additional Context
border-radius: 0.7rem;
for its buttons, and this change ensures consistency in the button styles across the website.