feat: documented new trigger filters are GA #6060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
do-not-merge/hold
knative-prow
bot
added
approved
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Calum Murray <[email protected]>
Cali0707
force-pushed
the
document-filters-going-ga
branch
from
9daffa4
to
5f32864
Compare
Signed-off-by: Calum Murray <[email protected]>
matzew
reviewed
Jul 23, 2024
| - cesql: "source LIKE '%commerce%' AND type IN ('order.created', 'order.updated', 'order.canceled')" | ||
| ``` | ||
|
|
||
| ### Legacy attributes filter |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pierDipi
reviewed
Jul 23, 2024
|
/hold |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
|
/hold Sorry @pierDipi - I hadn't seen your hold, I was just removing my earlier one 😅 |
knative-prow
bot
added
the
do-not-merge/hold
Signed-off-by: Calum Murray <[email protected]>
knative-prow-robot
added
the
needs-rebase
|
/cc @pierDipi |
knative-prow-robot
removed
the
needs-rebase
Signed-off-by: Calum Murray <[email protected]>
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
|
/cherry-pick release-1.15 |
|
@Cali0707: #6060 failed to apply on top of branch "release-1.15": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Cali0707
added a commit
to Cali0707/knative-docs
that referenced
this pull request
Aug 9, 2024
* feat: documented new trigger filters are GA Signed-off-by: Calum Murray <[email protected]> * fix: formatting Signed-off-by: Calum Murray <[email protected]> * cleanup: remove trigger filters feature file Signed-off-by: Calum Murray <[email protected]> * fix: redirect should work for experimental-features/new-trigger-filters Signed-off-by: Calum Murray <[email protected]> --------- Signed-off-by: Calum Murray <[email protected]>
knative-prow bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
* feat: documented new trigger filters are GA * fix: formatting * cleanup: remove trigger filters feature file * fix: redirect should work for experimental-features/new-trigger-filters --------- Signed-off-by: Calum Murray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the trigger documentation to reflect the fact that the new trigger filters are GA soon. Note: this should not be merged until after knative-extensions/eventing-kafka-broker#3964 has merged
/hold for knative-extensions/eventing-kafka-broker#3964