improved blog and case study section #5988
Conversation
knative-prow
bot
added
the
size/M
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/cc @zainabhusain227 @mmejia02 Can the two of you look at the design changes here? |
There was a problem hiding this comment.
Hey @ShravaniAK thanks for the improvements made here so far!
I left a few code quality comments (which should make it easier for us to have consistent responsiveness).
Outside of those, can you change the way that the quote class in the testimonial renders on the mobile view so that the blue line is not on the left of the quote, but is above the quote instead?
|
|
||
| <style> | ||
|
|
||
| @media (max-width: 768px) { |
There was a problem hiding this comment.
Can we make this width a css property variable so that this can become somthing like:
@media (max-width: var(--med-screen-width)) {There was a problem hiding this comment.
I tried, but I learned that CSS custom properties (variables) are not supported inside media query conditions.
| @@ -467,7 +467,14 @@ a.md-header__button.md-logo img { | |||
| .testimonials .find-links { | |||
| padding-top: 16px; | |||
| } | |||
|
|
|||
| @media screen and (max-width: 530px){ | |||
There was a problem hiding this comment.
Same here, can this become a css custom property?
|
I have changed the alignment of the line 
|
|
Hi @ShravaniAK - in the UX WG meeting today I was informed that we have also made typography changes on this page. Would you be able to implement those? If you look at the testimonials tab in https://www.figma.com/design/3arTeN4tR3byPKSkrzTibp/Knative-Website?node-id=434-7 you should be able to see the updated typography |
|
Yeah sure , I'll implement the typography changes and update the PR |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, ShravaniAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
The About section and the case study section are not responsive on all devices, I have added styling code to make it responsive on all devices.
previous:
updated :
