-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details for storage and knative services #5605
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/serving/services/storage.md
Outdated
Knative Serving integrates with K8s storage capabilities via supporting a subset of ephemeral storage volumes and via PersistentVolumeClaims(PVCs) volume types. | ||
In detail Knative Serving supports emptyDir by default, secret, configmap, projection and PVCs volume types. | ||
For more details on volume configuration check the related [feature flags](../configuration/feature-flags.md) when applicable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Knative Serving integrates with K8s storage capabilities via supporting a subset of ephemeral storage volumes and via PersistentVolumeClaims(PVCs) volume types. | |
In detail Knative Serving supports emptyDir by default, secret, configmap, projection and PVCs volume types. | |
For more details on volume configuration check the related [feature flags](../configuration/feature-flags.md) when applicable. | |
By default Serving supports the mounting the [volume types](https://kubernetes.io/docs/concepts/storage/volumes):`emptyDir`, `secret`, `configMap` and `projected`. [PersistentVolumes](https://kubernetes.io/docs/concepts/storage/persistent-volumes/) are supported but require a [feature flag](../configuration/feature-flags.md) to be enabled. |
docs/serving/services/storage.md
Outdated
In detail Knative Serving supports emptyDir by default, secret, configmap, projection and PVCs volume types. | ||
For more details on volume configuration check the related [feature flags](../configuration/feature-flags.md) when applicable. | ||
|
||
Here is an example of using PVCs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is an example of using PVCs: | |
Here is an example of using a persistent volume claim with a Knative Service: |
docs/serving/services/storage.md
Outdated
The example assumes that the user has enabled PVC support via the corresponding feature flag. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can drop this since we mention it above
The example assumes that the user has enabled PVC support via the corresponding feature flag. |
docs/serving/services/storage.md
Outdated
!!! warning | ||
Mounting large volumes may add considerable overhead to the application's start up time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider moving this before the example
config/nav.yml
Outdated
@@ -131,6 +131,7 @@ nav: | |||
# TODO: Add security section to docs? | |||
- Configure resource requests and limits: serving/services/configure-requests-limits-services.md | |||
- HTTPS redirection: serving/services/http-protocol.md | |||
- Configuring storage: serving/services/storage.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Configuring storage: serving/services/storage.md | |
- Volume Support: serving/services/storage.md |
@dprotaso thanks, comments addressed. |
@dprotaso gentle ping. |
add missing whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proposed Changes