Skip to content

Commit

Permalink
Fixing #5537: Adding mandatory target annotation and their units. (#5629
Browse files Browse the repository at this point in the history
)

* Issue# #5537: Update autoscaling-metrics.md to add the mandatory target values

As per issue  #5537,  creating this PR for adding mandatory target annotation.

* Fixing #5537: Implementing PR comments

* Fixing #5634: Update home.html

* Reverting the commit for other issue

Reverting the commit for other issue so that I can fork one branch per issue

* Fixing #5537: Adding review comments

* Fixing#5537: Updating note formatting

* Update autoscaling-metrics.md

* Update autoscaling-metrics.md

* Update autoscaling-metrics.md

* Update autoscaling-metrics.md
  • Loading branch information
erharjotsingh committed Jul 31, 2023
1 parent ac6b067 commit 9c9f95e
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions docs/serving/autoscaling/autoscaling-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ For more information about KPA and HPA, see the documentation on [Supported Auto
metadata:
annotations:
autoscaling.knative.dev/metric: "concurrency"
autoscaling.knative.dev/target-utilization-percentage: "70"
```
!!! note
The `autoscaling.knative.dev/target-utilization-percentage` annotation for "Concurrency" specifies a percentage value

=== "Requests per second"

Expand All @@ -47,7 +50,10 @@ For more information about KPA and HPA, see the documentation on [Supported Auto
metadata:
annotations:
autoscaling.knative.dev/metric: "rps"
autoscaling.knative.dev/target: "150"
```
!!! note
The `autoscaling.knative.dev/target` annotation for "Requests per second" specifies an integer value

=== "CPU"

Expand All @@ -63,7 +69,10 @@ For more information about KPA and HPA, see the documentation on [Supported Auto
annotations:
autoscaling.knative.dev/class: "hpa.autoscaling.knative.dev"
autoscaling.knative.dev/metric: "cpu"
autoscaling.knative.dev/target: "100"
```
!!! note
The `autoscaling.knative.dev/target` annotation for "CPU" specifies the integer value in millicore

=== "Memory"

Expand All @@ -79,7 +88,10 @@ For more information about KPA and HPA, see the documentation on [Supported Auto
annotations:
autoscaling.knative.dev/class: "hpa.autoscaling.knative.dev"
autoscaling.knative.dev/metric: "memory"
autoscaling.knative.dev/target: "75"
```
!!! note
The `autoscaling.knative.dev/target` annotation for "Memory" specifies the integer value in Mi

=== "Custom metric"

Expand All @@ -98,6 +110,7 @@ For more information about KPA and HPA, see the documentation on [Supported Auto
annotations:
autoscaling.knative.dev/class: "hpa.autoscaling.knative.dev"
autoscaling.knative.dev/metric: "<metric-name>"
autoscaling.knative.dev/target: "<target>"
```

Where `<metric-name>` is your custom metric.
Expand Down

0 comments on commit 9c9f95e

Please sign in to comment.