Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firatbezir as Knative eventing writer #1585

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

firatbezir
Copy link
Contributor

@firatbezir firatbezir commented Jun 21, 2024

Hi Knative team,

I am Firat Bezir, a mentee for the LFX Mentorship program working on the Knative Eventing Onboarding Improvement project. As part of my mentorship, I need to create and manage a project under the Knative organization.

Please add me as a member of the Knative organization to facilitate this process. By becoming a member, I will no longer need to use the ok-to-test labels to run tests, which will streamline my contributions and help me be more efficient in my work.

Changes:

  • Add @firatbezir as a member of the Knative organization and Knative-sandbox.

Release Note

N/A

@knative-prow knative-prow bot requested review from dprotaso and dsimansk June 21, 2024 11:04
Copy link

linux-foundation-easycla bot commented Jun 21, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

knative-prow bot commented Jun 21, 2024

Welcome @firatbezir! It looks like this is your first PR to knative/community 🎉

Copy link

knative-prow bot commented Jun 21, 2024

Hi @firatbezir. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2024
@dsimansk
Copy link
Contributor

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 21, 2024
@dsimansk
Copy link
Contributor

@pierDipi @Cali0707 @Leo6Leo can any of you ACK it's our new mentee pls? :)

@dsimansk
Copy link
Contributor

/approve
/lgtm

Adding hold to get Eventing WG +1.
/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
Copy link

knative-prow bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, firatbezir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@Leo6Leo
Copy link
Member

Leo6Leo commented Jun 21, 2024

/unhold Thanks @dsimansk
And welcome! @firatbezir

@Leo6Leo
Copy link
Member

Leo6Leo commented Jun 21, 2024

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2024
@knative-prow knative-prow bot merged commit 855631d into knative:main Jun 21, 2024
6 checks passed
@firatbezir firatbezir deleted the add-firatbezir-as-member branch June 21, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants