Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step down as client approver #1552

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

navidshaikh
Copy link
Contributor

Changes

I haven't been actively contributing to client for a while now, removing myself as approver for client and extensions.
/assign @aliok

Signed-off-by: Navid Shaikh <[email protected]>
@knative-prow knative-prow bot requested review from aliok and dprotaso April 17, 2024 20:57
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 17, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
Copy link

knative-prow bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@knative-prow knative-prow bot merged commit 8506ae2 into knative:main Apr 17, 2024
6 checks passed
@navidshaikh navidshaikh deleted the navids/step-down branch April 18, 2024 08:02
@aliok
Copy link
Member

aliok commented Apr 18, 2024

Thanks @navidshaikh

I hope our paths cross again in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants