Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update knative-extensions.yaml #1539

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Update knative-extensions.yaml #1539

merged 2 commits into from
Mar 26, 2024

Conversation

tzununbekov
Copy link
Member

In response to the received request - remove tzununbekov from the "approvers" role.

Changes

/kind

Fixes #

Release Note

Docs

@tzununbekov
Update knative-extensions.yaml
9e73f84 
Remove `tzununbekov` from approvers role
@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 26, 2024

@tzununbekov: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

In response to the received request - remove tzununbekov from the "approvers" role.

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 26, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2024
matzew
matzew approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
(but it does not 😢 )

/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@aliok
Copy link
Member

aliok commented Mar 26, 2024

Can you run the ./hack/update-codegen.sh

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@aliok
Copy link
Member

aliok commented Mar 26, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew, tzununbekov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@aliok
Copy link
Member

aliok commented Mar 26, 2024

Thanks Timur and you're welcome back anytime

@knative-prow knative-prow bot merged commit fd8471e into knative:main Mar 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@davidhadas davidhadas Awaiting requested review from davidhadas

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@matzew matzew

@aliok aliok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tzununbekov @aliok @matzew