-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add folks from RabbitMQ Team #1534
Conversation
@ikavgo: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @ikavgo. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
peribolos/knative-extensions.yaml
Outdated
@@ -1025,8 +1025,10 @@ orgs: | |||
eventing-rabbitmq: write | |||
members: | |||
- ikavgo | |||
- mkuratczyk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's first add folks to the member list, have then accept their invites. Then after add folks to the rabbitmq team.
This just avoids the churn with our machinery that updates the OWNER files across the repos.
After the changes you have to |
c305ab6
to
9cd1641
Compare
/lgtm :-) @dprotaso I think it's mergeble now |
9cd1641
to
2f25169
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ikavgo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind enchancement
Release Note
cc @dprotaso @mkuratczyk