Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add folks from RabbitMQ Team #1534

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Mar 18, 2024

Changes

/kind enchancement

Release Note

Add Michal Kuratczyk and Aitor Pérez Cedres from RabbitMQ Team

cc @dprotaso @mkuratczyk

Copy link

knative-prow bot commented Mar 18, 2024

@ikavgo: The label(s) kind/enchancement cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind enchancement

Release Note

Add Michal Kuratczyk from RabbitMQ Team

cc @dprotaso @mkuratczyk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 18, 2024
Copy link

knative-prow bot commented Mar 18, 2024

Hi @ikavgo. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2024
@ikavgo ikavgo changed the title Add Michal Kuratczyk from RabbitMQ Team Add folks from RabbitMQ Team Mar 18, 2024
@ikavgo
Copy link
Contributor Author

ikavgo commented Mar 18, 2024

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2024
@@ -1025,8 +1025,10 @@ orgs:
eventing-rabbitmq: write
members:
- ikavgo
- mkuratczyk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's first add folks to the member list, have then accept their invites. Then after add folks to the rabbitmq team.

This just avoids the churn with our machinery that updates the OWNER files across the repos.

@dprotaso
Copy link
Member

After the changes you have to ./hack/update-codegen.sh

@ikavgo ikavgo force-pushed the ikavgo-add-michal-kuratczyk branch from c305ab6 to 9cd1641 Compare March 20, 2024 09:09
@ikavgo
Copy link
Contributor Author

ikavgo commented Mar 20, 2024

/lgtm :-)

@dprotaso I think it's mergeble now

@ikavgo ikavgo force-pushed the ikavgo-add-michal-kuratczyk branch from 9cd1641 to 2f25169 Compare March 21, 2024 10:40
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2024
Copy link

knative-prow bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ikavgo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2024
@knative-prow knative-prow bot merged commit 6222361 into knative:main Mar 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants