Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove nrrso until he accepts GitHub org invites #1533

Merged
merged 1 commit into from
Mar 15, 2024
Merged

remove nrrso until he accepts GitHub org invites #1533

merged 1 commit into from
Mar 15, 2024

Conversation

dprotaso
Copy link
Member

This unblocks the OWNER files being propagated until nrrso accepts the GitHub invites.

Once he accepts we can add him back to the steering team

@knative-prow knative-prow bot requested a review from krsna-m March 15, 2024 14:07
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@knative-prow knative-prow bot requested a review from psschwei March 15, 2024 14:07
@dprotaso
Copy link
Member Author

/assign @aliok @upodroid

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 15, 2024
upodroid
upodroid approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit bc2fee5 into knative:main Mar 15, 2024
6 checks passed
@dprotaso dprotaso deleted the nrrso branch March 25, 2024 18:22
dprotaso added a commit to dprotaso/community that referenced this pull request Mar 25, 2024
@dprotaso
Drop extra files that were committed in knative#1533
e52ebcb 
I added some files I didn't expect to add. The active user list is
probably over 2 years old (that's the last time I pruned the list).
knative-prow bot pushed a commit that referenced this pull request Mar 25, 2024
@dprotaso
Drop extra files that were committed in #1533 (#1537)
e48958b 
I added some files I didn't expect to add. The active user list is
probably over 2 years old (that's the last time I pruned the list).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@krsna-m krsna-m Awaiting requested review from krsna-m

@psschwei psschwei Awaiting requested review from psschwei

Assignees

@aliok aliok

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dprotaso @upodroid @aliok