Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

membership: add sadath-12 #1519

Merged
merged 1 commit into from
Feb 26, 2024
Merged

membership: add sadath-12 #1519

merged 1 commit into from
Feb 26, 2024

Conversation

sadath-12
Copy link
Contributor

Changes

Add @sadath-12 as a member to the community since he has been working on fixing issues and raising pr's https://github.com/pulls?q=is%3Apr+author%3Asadath-12+archived%3Afalse+knative%2Feventing+ and is active in the community .
He wants to continue this journey with knative

/kind

Fixes #

Release Note


Docs


Signed-off-by: syedsadath-17 <[email protected]>
Copy link

knative-prow bot commented Feb 23, 2024

@sadath-12: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

Add @sadath-12 as a member to the community since he has been working on fixing issues and raising pr's https://github.com/pulls?q=is%3Apr+author%3Asadath-12+archived%3Afalse+knative%2Feventing+ and is active in the community .
He wants to continue this journey with knative

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

knative-prow bot commented Feb 23, 2024

Welcome @sadath-12! It looks like this is your first PR to knative/community 🎉

Copy link

knative-prow bot commented Feb 23, 2024

Hi @sadath-12. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2024
@ReToCode
Copy link
Member

cc @creydr @pierDipi

@ReToCode
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2024
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from my side. Thanks @sadath-12 for your contributions so far and your support in the community.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2024
@dprotaso
Copy link
Member

/approve

Copy link

knative-prow bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, sadath-12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@knative-prow knative-prow bot merged commit a61878f into knative:main Feb 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants