Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding myself as member of func-writers #1517

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Adding myself as member of func-writers #1517

merged 1 commit into from
Feb 20, 2024

Conversation

matzew
Copy link
Member

@matzew matzew commented Feb 20, 2024

Changes

  • adding matzew as member of func-writers

/kind

Fixes #

Release Note

Docs

@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 20, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • adding matzew as member of func-writers

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2024
@matejvasek
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@ReToCode
Copy link
Member

Please run ./hack/update-codegen.sh.

;)

@matzew
Adding myself as member of func-writers
bcb7a09 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew matzew force-pushed the adding_matzew_as_func_approver branch from 4465005 to bcb7a09 Compare February 20, 2024 14:01
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@matejvasek
Copy link
Contributor

PTAL @ReToCode @evankanderson @dprotaso

@ReToCode
Copy link
Member

According to owners, needs approval from

/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team February 20, 2024 14:10
@dsimansk
Copy link
Contributor

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matejvasek, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2024
@knative-prow knative-prow bot merged commit 6079fb7 into knative:main Feb 20, 2024
5 checks passed
@lkingland
Copy link
Member

/approve
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk Awaiting requested review from dsimansk

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@matejvasek matejvasek

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matzew @matejvasek @ReToCode @dsimansk @lkingland