Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xiangpingjiang to knative and knative-extensions #1488

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

xiangpingjiang
Copy link
Contributor

Changes

I'm adding myself as a knative and knative-sandbox member so I don't need to wait for the ok-to-test labels.

My contributions so far have been:
eventing
client
docs
serving

cc @Cali0707 @creydr @dsimansk

Copy link

knative-prow bot commented Jan 15, 2024

Welcome @xiangpingjiang! It looks like this is your first PR to knative/community 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 15, 2024
Copy link

knative-prow bot commented Jan 15, 2024

Hi @xiangpingjiang. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2024
@Cali0707
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 15, 2024
@Cali0707
Copy link
Member

LGTM from my side!

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi January 15, 2024 16:00
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
@pierDipi
Copy link
Member

/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team January 15, 2024 16:04
@creydr
Copy link
Member

creydr commented Jan 15, 2024

LGTM from my side too. Thanks a lot for your contributions on the OIDC work @xiangpingjiang so far!

/lgtm

@Leo6Leo
Copy link
Member

Leo6Leo commented Jan 15, 2024

That's so amazing! Thanks for all the work you have done @xiangpingjiang , so happy for you!

@dprotaso
Copy link
Member

/approve

Copy link

knative-prow bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pierDipi, xiangpingjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@knative-prow knative-prow bot merged commit d7751d2 into knative:main Jan 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants