Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chainguard taking ownership of eventing-rabbitmq #1486

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

dprotaso
Copy link
Member

As a results of some restructuring due to the VMware/Broadcom acquisition we're unable to maintain this integration.

I've chatted with Chainguard and they use this integration in production so I'm transitioning approver responsibilities to them.

If anyone else would also like approver status I'd imagine the help would be welcome.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2024
@dprotaso
Copy link
Member Author

/assign @tcnghia

/hold there's been some changes in knative/eventing that broke the integration (knative-extensions/eventing-rabbitmq#1310)

Will unhold when that's fixed.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2024
@dprotaso
Copy link
Member Author

cc @gabo1208

@gabo1208
Copy link
Member

I could be left as an approver if that's ok

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
Copy link

knative-prow bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member Author

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2024
@knative-prow knative-prow bot merged commit 48a53b0 into knative:main Jan 12, 2024
5 checks passed
@dprotaso dprotaso deleted the nghia-approver branch January 12, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants