Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new approvers to eventing-natss #1479

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

dan-j
Copy link
Contributor

@dan-j dan-j commented Jan 2, 2024

@astelmashenko and I have been heavily involved in the improvement of the JetStream support in eventing-natss and would like to become approvers of the project. We're already community members so I believe this is the only change we need to make?

At the moment the only approver is @zhaojizhuang, if you would like to provide your 👍 or some feedback on anything better we can do?

Thanks

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 2, 2024
Copy link

knative-prow bot commented Jan 2, 2024

Hi @dan-j. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 2, 2024
@astelmashenko and I have been heavily involved in the improvement of the JetStream support in eventing-natss and would like to become approvers of the project.

At the moment the only approver is @zhaojizhuang, if you would like to provide your 👍 or some feedback on anything better we can do?

Thanks
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
@pierDipi
Copy link
Member

pierDipi commented Jan 2, 2024

/cc @knative/technical-oversight-committee

@knative-prow knative-prow bot requested a review from a team January 2, 2024 13:16
Copy link

knative-prow bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dan-j, pierDipi, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@knative-prow knative-prow bot merged commit 0d31772 into knative:main Jan 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants