Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Leo6Leo as eventing reviewer #1449

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Added Leo6Leo as eventing reviewer #1449

merged 2 commits into from
Oct 16, 2023

Conversation

Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Oct 13, 2023

Changes

Add @Leo6Leo as eventing reviewer
Add @Leo6Leo as eventing kafka broker reviewer

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2023
@Leo6Leo
Copy link
Member Author

Leo6Leo commented Oct 13, 2023

/cc @Cali0707 @pierDipi @dsimansk

pierDipi
pierDipi approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
psschwei
psschwei reviewed Oct 16, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@knative-prow
Copy link

knative-prow bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, pierDipi, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@knative-prow knative-prow bot merged commit 8884bb3 into knative:main Oct 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

@pierDipi pierDipi pierDipi approved these changes

@davidhadas davidhadas Awaiting requested review from davidhadas

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leo6Leo @pierDipi @psschwei