Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust release leads to the schedule for the upcoming 1.12 release #1443

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Adjust release leads to the schedule for the upcoming 1.12 release #1443

merged 1 commit into from
Oct 10, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Oct 10, 2023 •
edited
Loading

Changes

/assign @skonto

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2023
@skonto
Copy link
Contributor

skonto commented Oct 10, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@skonto
Copy link
Contributor

skonto commented Oct 10, 2023

/hold could you add the rest too?

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@skonto
Copy link
Contributor

skonto commented Oct 10, 2023

/approve

@skonto
Copy link
Contributor

skonto commented Oct 10, 2023 •
edited
Loading

@ReToCode I think you only need to add Cali0707, creydr is already there. I am trying to avoid another PR.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2023
@ReToCode ReToCode changed the title Add myself to Release Leads Adjust release leads to the schedule for the upcoming 1.12 release Oct 10, 2023
@ReToCode
Copy link
Member Author

@skonto Done. I also removed Vishal-Chdhry as he is not in the release rooster or in this release as a lead.

@skonto
Copy link
Contributor

skonto commented Oct 10, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@skonto
Copy link
Contributor

skonto commented Oct 10, 2023

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2023
@skonto
Copy link
Contributor

skonto commented Oct 10, 2023

/approve

@ReToCode
Copy link
Member Author

/assign @dsimansk

@skonto skonto added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 69f51c0 into knative:main Oct 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso Awaiting requested review from dprotaso

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@dsimansk dsimansk

@skonto skonto

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ReToCode @skonto @dsimansk