Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose to create the new repo serving-progressive-rollout #1435

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Propose to create the new repo serving-progressive-rollout #1435

merged 4 commits into from
Sep 19, 2023

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Sep 15, 2023 •
edited
Loading

Changes

  • This PR proposed to create a new repo called serving-progressive-rollout to implement an extension rolling out the serving revision progressively.

/kind

Fixes #1434

Release Note

Docs

@knative-prow
Copy link

knative-prow bot commented Sep 15, 2023

@houshengbo: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2023
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2023
@dprotaso
Copy link
Member

dprotaso commented Sep 18, 2023 •
edited
Loading

Rather than wait for the TOC meeting I figure we could do this repo approvals async. Unless someone wants to discuss this - then we can add it to the agenda for the next meeting.

cc @knative/technical-oversight-committee

I'm a +1

@psschwei
Copy link
Contributor

+1

@davidhadas
Copy link
Contributor

+1
Assuming the team has worked the integration with serving WG.

@dprotaso, @houshengbo
Is it planned to eventually land in serving to replace the current rollout strategy?

@dprotaso
Copy link
Member

dprotaso commented Sep 18, 2023 •
edited
Loading

Is it planned to eventually land in serving to replace the current rollout strategy?

No

@houshengbo
Copy link
Contributor Author

It will be an option for users to use to replace the existing rollout strategy.
First they need to install serving, and then this extension in order to make it work.

@dprotaso
Copy link
Member

We have quorum but worth pinging @kvmware and @dsimansk for their input

@krsna-m
Copy link
Contributor

krsna-m commented Sep 19, 2023

I gave my 👍 on Pauls +1 comment awhile ago. Sorry, should have made own comment.

@dsimansk
Copy link
Contributor

+1 from me as well.

@dprotaso
Copy link
Member

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2023
@knative-prow knative-prow bot merged commit 305b700 into knative:main Sep 19, 2023
5 checks passed
@skonto skonto mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Technical Oversight Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Repo: serving-progressive-rollout
6 participants
@houshengbo @dprotaso @psschwei @davidhadas @krsna-m @dsimansk