Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update knative-extensions.yaml #1423

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Update knative-extensions.yaml #1423

merged 1 commit into from
Aug 31, 2023

Conversation

menehune23
Copy link
Contributor

Remove menehune23

@knative-prow
Copy link

knative-prow bot commented Aug 22, 2023

Welcome @menehune23! It looks like this is your first PR to knative/community 🎉

@knative-prow
Copy link

knative-prow bot commented Aug 22, 2023

Hi @menehune23. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@krsna-m krsna-m removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 23, 2023
@dprotaso
Copy link
Member

/approve

@knative-prow
Copy link

knative-prow bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, gabo1208, menehune23

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@dprotaso
Copy link
Member

@menehune23 you'll need to run ./hack/update-codegen.sh

@menehune23
Update knative-extensions.yaml
c8b7006 
Remove menehune23

Signed-off-by: menehune23 <[email protected]>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@menehune23
Copy link
Contributor Author

@dprotaso OK, done. Thanks!

@dprotaso
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@knative-prow knative-prow bot merged commit 7644711 into knative:main Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabo1208 gabo1208 gabo1208 approved these changes

@dprotaso dprotaso Awaiting requested review from dprotaso

@krsna-m krsna-m Awaiting requested review from krsna-m

Assignees

@dprotaso dprotaso

@gabo1208 gabo1208

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@menehune23 @dprotaso @gabo1208 @krsna-m